HashStore 1.1.0 Release #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doulikecookiedough
assigned doulikecookiedough and artntek and unassigned doulikecookiedough
artntek
approved these changes
Jan 25, 2024
|
Thanks again @artntek for your review! I've made the updates in another branch and merged them into develop. I'm also going to hold off on the 1.1.0 release until the changes to |
…rmatid is passed, causing metadata document names created via the client to be incorrect
Feature-94: Client Bug Fixes
…update_refs_file'
…object' process and related methods
Feature-93: Additional Logging Statements
…bject' if the cid is currently in use
…on threads with multiple pids for one cid
…ct the appropriate thread or multiprocessing 'tag_object'
…or a shared list if multiprocessing is being used
… use multiprocessing lock and list when global variable set appropriately
…if syntax instead of pre-generating exist booleans
…eption and adding a new debug statement, and update pytest
… setup tmp refs files and paths outside of synchronization code
…ing 'os.path.isfile'
…nd clean-up pytest
Feature-139: Path Construction & Clean Up
…n with 'yaml' library, and then join separately with a comments string to minimize yaml gotchas
Feature-138: Construct HashStore Config Yaml with Library
…r properties have been checked
…to get a logger instance for the 'filehashstore' module name and revise init process
… logging messages in 'delete_object'
… try block, and another bug where a cid was not locked during an exception scenario
…x potential dead lock due to sync being outside try block
…hods, and optimize sync method logging calls, add missing logging statements
…in try block which could lead to dead lock
Feature-140: Logging Enhancement
Feature-108: Citation Update Part 2
…ashstore test module
Closed
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
cidand creating reference filespidreference file that contains thecid, and acidreference file that containspids that reference acidtag_objectto create the reference files (else create an orphaned object), and optionallydelete_if_invalid_objectshould they have data they want to validate theobject_metadatareturned from storing an object.pid+format_idand in a directory formed using the hash of the pid in/metadatatag_object,delete_if_invalid_objecthashstoreconfig file is now separated in two pieces, with the actual .yaml content being formed with a librarypoetry installsphinx-autodocumentationalong with typehintsREADME.mdto provide context to the HashStore library and how-to sections.Greetings @artntek - When you have scope, can you please help review
HashStoreto assist me in releasingHashStore 1.1.0? Please do not hesitate to scrutinize any of the code or bring to my attention any concerns. Thank you 🙏!