Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature-138: Construct HashStore Config Yaml with Library #144

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Feature-138: Construct HashStore Config Yaml with Library #144

merged 1 commit into from
Sep 26, 2024

Conversation

doulikecookiedough
Copy link
Contributor

Summary of Changes:

  • Refactored the hashstore config hashstore.yaml content creation into two parts:
    • Comments
      • This is a string
    • Key-Value Pairs
      • These pairs are now generated through the yaml (PyYAML) library via yaml.dump(...)
  • These two pieces are combined together afterwards
    • The final hashstore config hashstore.yaml content begins with the comments and the key-value pairs follow immediately after

@doulikecookiedough
Refactor '_build_hashstore_yaml_string' to create yaml content portio…
efd3cb5 
…n with 'yaml' library, and then join separately with a comments string to minimize yaml gotchas
@doulikecookiedough doulikecookiedough merged commit d5e2341 into develop Sep 26, 2024
2 checks passed
@doulikecookiedough doulikecookiedough mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@doulikecookiedough