feat: expose TraceId and ParentID to other plugins #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds two fields to `kong.ctx.shared` and `ngx.var`: - `datadog_sdk_trace_id`: TraceId of the current span. - `datadog_sdk_span_id`: SpanId of the current span. Those fields can be consumed by other Kong plugins or in the underlying NGINX configuration for log correlation.
pablomartinezbernardo
approved these changes
May 24, 2024
- Remove ngx.var - config.service is not required anymore
|
Since your last review, I added an example. Would you mind checking if it works for you? 🙇 |
pablomartinezbernardo
approved these changes
Jun 3, 2024
Co-authored-by: pablomartinezbernardo <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 92.68% 92.68%
=======================================
Files 7 7
Lines 615 615
=======================================
Hits 570 570
Misses 45 45 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds two fields to
kong.ctx.sharedandngx.var:datadog_sdk_trace_id: TraceId of the current span.datadog_sdk_span_id: SpanId of the current span.Those fields can be consumed by other Kong plugins or in the underlying NGINX configuration for log correlation.
Resolves #25