Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tag span with w3c parent state #60

Merged
merged 1 commit into from
May 23, 2024
Merged

feat: tag span with w3c parent state #60

merged 1 commit into from
May 23, 2024

Conversation

dmehala
Copy link
Contributor

@dmehala dmehala commented May 22, 2024

Description

Implement W3C phase 2

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.68%. Comparing base (59ee542) to head (253206e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   92.67%   92.68%   +0.01%     
==========================================
  Files           7        7              
  Lines         614      615       +1     
==========================================
+ Hits          569      570       +1     
  Misses         45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@mabdinur mabdinur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can we run the parametric tests against the Kong plugin? It would be nice to run these changes against the w3c_p_inject and p_extract tests.

@dmehala
Copy link
Contributor Author

dmehala commented May 23, 2024

Can we run the parametric tests against the Kong plugin?

No unfortunately.

@dmehala dmehala merged commit 15d7bd3 into main May 23, 2024
3 checks passed
@dmehala dmehala deleted the dmehala/w3c-phase-2 branch May 23, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants