Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fiddler agent to replace deprecated v2 APIs with faster v3 APIs. #2582

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

nikhil-singh-01
Copy link

@nikhil-singh-01 nikhil-singh-01 commented Jan 17, 2025

What does this PR do?
This PR rewrites Fiddler's Agent to use new faster v3 APIs. The PR ensures that the results published to DataDog continue to be backwards compatible supporting old metrics names.
Changes:

  • Replace v2 APIs - /models, /metrics and /queries with v3 APIs and remove usage of v2/list-projects API.
  • Maintain backward compatibility for old metrics names(using v1compat flag) and add another dashboard for newer metric names.
  • Add new metric names to metadata.csv
  • Update spec.yaml to make FiddlerCheck more configurable.
  • Update and add tests for v3 APIs and v1compat flag turned off.

Motivation
What inspired you to submit this pull request?
Functional Reasons:

The existing implementation of Fiddler-Datadog integration uses v2 APIs - list_projects, and v2/queries and metrics
These APIs are deprecated and removed once users are successfully migrated.
These APIs are replaced by v3 APIs which have been in production for 10+ months. These APIs make much more efficient use of caching at every layer, and are faster.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

Anything else we should know when reviewing?

@bgoldberg122 bgoldberg122 added the assets/no-deploy Prevents APW from deploying this PR in staging label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets/no-deploy Prevents APW from deploying this PR in staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants