-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Celery Integration #19953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Celery Integration #19953
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
# TYPE flower_events_total counter | ||
flower_events_total{task="tasks.add",type="task-received",worker="celery@b418c0493d46"} 1141.0 | ||
flower_events_total{task="tasks.add",type="task-started",worker="celery@b418c0493d46"} 1141.0 | ||
flower_events_total{task="tasks.multiply",type="task-received",worker="celery@b418c0493d46"} 1141.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know what happens to the tag when there's a @
do we normalize it to _
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep yep!
* Initial Release * Add Celery end to end environment * Update manifest * minor fixes * ddev valdidate ci --sync * lint * validate manifest description * add Celery to labeler.yml * Enable log collection in E2E 94e3c7c
What does this PR do?
This PR just addresses implementation for Celery - assets will come in a separate PR.
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged