Skip to content

Celery Integration #19953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 1, 2025
Merged

Celery Integration #19953

merged 10 commits into from
Apr 1, 2025

Conversation

Kyle-Neale
Copy link
Contributor

@Kyle-Neale Kyle-Neale commented Mar 27, 2025

What does this PR do?

This PR just addresses implementation for Celery - assets will come in a separate PR.

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.95%. Comparing base (01712de) to head (e148d98).
Report is 8 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
celery 95.45% <95.45%> (?)
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@NouemanKHAL NouemanKHAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

# TYPE flower_events_total counter
flower_events_total{task="tasks.add",type="task-received",worker="celery@b418c0493d46"} 1141.0
flower_events_total{task="tasks.add",type="task-started",worker="celery@b418c0493d46"} 1141.0
flower_events_total{task="tasks.multiply",type="task-received",worker="celery@b418c0493d46"} 1141.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what happens to the tag when there's a @ do we normalize it to _?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep yep!

@Kyle-Neale Kyle-Neale added this pull request to the merge queue Apr 1, 2025
Merged via the queue into master with commit 94e3c7c Apr 1, 2025
55 of 56 checks passed
@Kyle-Neale Kyle-Neale deleted the kyle.neale/celery-integration branch April 1, 2025 19:12
github-actions bot pushed a commit that referenced this pull request Apr 1, 2025
* Initial Release

* Add Celery end to end environment

* Update manifest

* minor fixes

* ddev valdidate ci --sync

* lint

* validate manifest description

* add Celery to labeler.yml

* Enable log collection in E2E 94e3c7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants