-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add Fortigate port and switch table #19934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good once tests are updated and are passing
Review from urseberry is dismissed. Related teams and files:
- documentation
- snmp/tests/compose/data/fortinet-fortigate.snmprec
What does this PR do?
FORTINET-FORTIGATE-MIB
fgSwDeviceTable
andfgSwPortTable
switch_name
andswitch_serial
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged