Skip to content

Add Fortigate port and switch table #19934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

UTXOnly
Copy link
Contributor

@UTXOnly UTXOnly commented Mar 25, 2025

What does this PR do?

  • Adds support for FORTINET-FORTIGATE-MIB fgSwDeviceTable and fgSwPortTable
    • enables monitoring of managed switch ports and switch resource usage tagged by switch_name and switch_serial

Motivation

  • Zendesk support case #2013960

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.29%. Comparing base (1cc5061) to head (7cc8467).
Report is 176 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
celery ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
presto ?
snmp 95.72% <100.00%> (?)
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@NouhaManai96 NouhaManai96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good once tests are updated and are passing

urseberry
urseberry previously approved these changes May 15, 2025
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed urseberry’s stale review May 15, 2025 20:22

Review from urseberry is dismissed. Related teams and files:

  • documentation
    • snmp/tests/compose/data/fortinet-fortigate.snmprec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants