Clarify secret naming in EKS Fargate sidecar injection doc #19871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urseberry
reviewed
Mar 18, 2025
sblumenthal
previously approved these changes
Mar 31, 2025
urseberry
previously approved these changes
Mar 31, 2025
temporal-github-worker-1
bot
added
docs/approved
and removed
docs/review-requested
labels
Co-authored-by: Ursula Chen <[email protected]>
temporal-github-worker-1
bot
dismissed stale reviews from sblumenthal and urseberry
Review from sblumenthal is dismissed.
Related teams and files:
- container-integrations
- eks_fargate/README.md
Review from urseberry is dismissed.
Related teams and files:
- eks_fargate/README.md
- documentation
- eks_fargate/README.md
Co-authored-by: Ursula Chen <[email protected]>
temporal-github-worker-1
bot
added
docs/review-requested
and removed
docs/approved
labels
|
@urseberry, sorry missed to add your commits. Updated now. |
sblumenthal
approved these changes
Mar 31, 2025
urseberry
approved these changes
Mar 31, 2025
temporal-github-worker-1
bot
added
docs/approved
and removed
docs/review-requested
labels
steveny91
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Clarifying secret naming.
DataDog/datadog-operator#1688
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged