FoundationDB: Respect 'tls_ca_file' and 'tls_password' config options #19865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesreprise
changed the title
jamesreprise
commented
Mar 18, 2025
| if 'tls_certificate_file' in self.instance: | ||
| fdb.options.set_tls_cert_path(self.instance.get('tls_certificate_file')) | ||
| if 'tls_password' in self.instance: |
There was a problem hiding this comment.
See https://apple.github.io/foundationdb/api-python.html
fdb.options.set_tls_password(password)
Sets the passphrase for encrypted private key. Password should be set before setting the key for the password to be used.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dkirov-dd
approved these changes
Mar 24, 2025
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the FoundationDB check so that the 'tls_ca_file' and 'tls_password' options are respected.
Motivation
They weren't being respected.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged