Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin beautifulsoup #19538

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Pin beautifulsoup #19538

merged 4 commits into from
Feb 3, 2025

Conversation

sarah-witt
Copy link
Contributor

@sarah-witt sarah-witt commented Feb 3, 2025

What does this PR do?

Pins beautifulsoup

Motivation

CI validation for readmes started failing on the new beautiful soup release this AM

│                                                                                                  │
│   149 │   else:                                                                                  │
│   150 │   │   curr_header = soup.find('h2', text=header)                                         │
│   151 │   │   curr_instructions = curr_header.find_next()                                        │
│ ❱ 152 │   │   if curr_instructions.name == "h2":                                                 │
│   153 │   │   │   files_failed[readme_path] = True                                               │
│   154 │   │   │   display_queue.append((echo_failure, f"     readme has an empty {header} H2 (   │
│   155                                                                                            │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
AttributeError: 'NoneType' object has no attribute 'name'

https://groups.google.com/g/beautifulsoup/c/GHpJYIlF6AA
https://groups.google.com/g/beautifulsoup/c/M_vgwfO0RLA

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@sarah-witt sarah-witt marked this pull request as ready for review February 3, 2025 16:29
@sarah-witt sarah-witt requested a review from a team as a code owner February 3, 2025 16:29
steveny91
steveny91 previously approved these changes Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (405c681) to head (f806265).
Report is 8 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
datadog_checks_dev 77.63% <ø> (ø)
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

This reverts commit 50a7520.
@sarah-witt sarah-witt added this pull request to the merge queue Feb 3, 2025
Merged via the queue into master with commit e603568 Feb 3, 2025
35 checks passed
@sarah-witt sarah-witt deleted the sarah/pin-ddev-beautiful-soup branch February 3, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants