Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pgbouncer v1.23 to tested versions #19534

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

nubtron
Copy link
Contributor

@nubtron nubtron commented Feb 3, 2025

What does this PR do?

The PR adds 1.23 to the tested versions of pgbouncer.
pgbouncer 1.23 is tested with postgres v15.5.

I used the bitnami pgbouncer image because pgbouncer/pgbouncer is no longer updated.

Motivation

The most recent version of pgbouncer we're testing is from 2019.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@nubtron nubtron added changelog/no-changelog qa/skip-qa Automatically skip this PR for the next QA labels Feb 3, 2025
@nubtron nubtron requested a review from a team as a code owner February 3, 2025 09:56
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.08%. Comparing base (3c32bea) to head (d6b0074).
Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
cassandra_nodetool ?
couch ?
gearmand ?
harbor ?
hive ?
hivemq ?
hudi ?
ibm_ace ?
ibm_was ?
ignite ?
jboss_wildfly ?
kafka ?
pgbouncer 91.74% <100.00%> (+0.07%) ⬆️
presto ?
rabbitmq ?
ray ?
scylla ?
solr ?
teamcity ?
vertica ?
voltdb ?
vsphere ?
zk ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@dkirov-dd
Copy link
Contributor

I think you need to run the linter:
ddev test -fs pgbouncer

iliakur
iliakur previously approved these changes Feb 3, 2025
@nubtron nubtron marked this pull request as draft February 3, 2025 10:33
@nubtron
Copy link
Contributor Author

nubtron commented Feb 3, 2025

@iliakur thanks for the tip! It's passing the lint check now but it's throwing an exception at the readme check. It's not happening locally for me, setting this PR to draft while I investigate.

@nubtron nubtron marked this pull request as ready for review February 7, 2025 09:45
@nubtron
Copy link
Contributor Author

nubtron commented Feb 7, 2025

Oops, I meant @dkirov-dd thanks for the tip 😊!

@nubtron nubtron merged commit 7636362 into master Feb 7, 2025
31 checks passed
@nubtron nubtron deleted the nubtron/pgbouncer_add_new_version_to_tests branch February 7, 2025 11:00
github-actions bot pushed a commit to bhargavnariyanicrest/integrations-core that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/skip-qa Automatically skip this PR for the next QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants