[AI-4764] DDS: Ivanti Connect Secure Integration v1.0.0 #19237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neko-dd
added
the
editorial review
|
Created DOCS-9701 for Docs team review. |
torosmassa
changed the title
HadhemiDD
previously approved these changes
Dec 30, 2024
iliakur
previously approved these changes
Jan 14, 2025
thibaultkrebs
added
the
assets/deploy-logs-staging
thibaultkrebs
previously approved these changes
Jan 17, 2025
|
@shubhamvekariya-crest you can run this command to fix the license headers: |
temporal-github-worker-1
bot
dismissed stale reviews from iliakur and HadhemiDD
Stale Review dismissed by prbot
temporal-github-worker-1
bot
added
agent/review-requested
and removed
agent/approved
labels
Done, Fixed |
jhgilbert
reviewed
Jan 22, 2025
ivanti_connect_secure/README.md
Outdated
|
|
||
| #### Log collection | ||
|
|
||
| 1. Collecting logs is disabled by default in the Datadog Agent. Enable it in the `datadog.yaml`: |
There was a problem hiding this comment.
Suggested change
| 1. Collecting logs is disabled by default in the Datadog Agent. Enable it in the `datadog.yaml`: | |
| 1. Collecting logs is disabled by default in the Datadog Agent. Enable it in `datadog.yaml`: |
or "the datadog-yaml file"
There was a problem hiding this comment.
updated to in `datadog.yaml`:
ivanti_connect_secure/README.md
Outdated
| 4. Under **Select Events to Log**, ensure all event types are selected. | ||
| 5. Click **Save Changes** to apply the configuration. | ||
| 6. Configure the syslog server details in the **Syslog Servers** section: | ||
| - **Server name/IP**: Enter the fully qualified domain name or IP address of the syslog server in the format `<IP/domain>:<port>`. |
There was a problem hiding this comment.
Suggested change
| - **Server name/IP**: Enter the fully qualified domain name or IP address of the syslog server in the format `<IP/domain>:<port>`. | |
| - **Server name/IP**: Enter the fully qualified domain name or IP address of the syslog server in the format `<IP/DOMAIN>:<PORT>`. |
ivanti_connect_secure/assets/dashboards/ivanti_connect_secure_statistics_and_system_status.json
Outdated
Show resolved
Hide resolved
| { | ||
| "id": 6592991177188294, | ||
| "definition": { | ||
| "title": "Detected Files over time", |
There was a problem hiding this comment.
Suggested change
| "title": "Detected Files over time", | |
| "title": "Detected Files over Time", |
ivanti_connect_secure/assets/dashboards/ivanti_connect_secure_statistics_and_system_status.json
Outdated
Show resolved
Hide resolved
| { | ||
| "id": 8702748035003160, | ||
| "definition": { | ||
| "title": "Web Requests Logs over time", |
There was a problem hiding this comment.
Suggested change
| "title": "Web Requests Logs over time", | |
| "title": "Web Requests Logs over Time", |
ivanti_connect_secure/assets/dashboards/ivanti_connect_secure_web_requests.json
Outdated
Show resolved
Hide resolved
abhi-modugula
approved these changes
Jan 30, 2025
jhgilbert
approved these changes
Jan 31, 2025
temporal-github-worker-1
bot
added
docs/approved
and removed
docs/review-requested
labels
iliakur
approved these changes
Feb 3, 2025
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
github-actions bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
* Added ivanti connect secure integration * Fix changelog CI failure * Resolve CI failures * Resolve CI failures * Resolve CI failures * Resolve CI failures * Resolve CI failures * Update pipeline * Update Authentication grok Parser * Update Authentication dashboard * Update parser name * Fix the license headers * Address review comments --------- Co-authored-by: Thibault Krebs <[email protected]> 401100e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR for a new integration Ivanti Connect Secure 1.0.0
Additional Notes
-- OOTB detection rules JSON would be shared separately with the required teams as a part of separate repository .
-- Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current datadog behaviour.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged