Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DOCS-8048) Adds default value for timeout #17618

Merged
merged 2 commits into from
May 29, 2024

Conversation

neko-dd
Copy link
Contributor

@neko-dd neko-dd commented May 23, 2024

What does this PR do?

Adds default value for timeout.

Motivation

Customer request through Zendesk

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

jhgilbert
jhgilbert previously approved these changes May 23, 2024
Copy link
Contributor

@jhgilbert jhgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor data type nit, thanks!

http_check/README.md Outdated Show resolved Hide resolved
Kyle-Neale
Kyle-Neale previously approved these changes May 24, 2024
Co-authored-by: Jen Gilbert <[email protected]>
@neko-dd neko-dd dismissed stale reviews from Kyle-Neale and jhgilbert via 7e4d119 May 28, 2024 20:32
@neko-dd neko-dd merged commit 28ad224 into master May 29, 2024
37 checks passed
@neko-dd neko-dd deleted the neko/DOCS-8048-http-check-timeout branch May 29, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants