-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mongo] mongodb operation sampling with DBM #17596
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justiniso
reviewed
May 20, 2024
The |
The |
ynnadkrap
previously approved these changes
May 22, 2024
nenadnoveljic
approved these changes
May 29, 2024
ynnadkrap
approved these changes
May 29, 2024
Kyle-Neale
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new feature to support mongodb operation sampling when DBM is enabled. The change includes
$currentOp
aggregation pipeline. Sampled operation includes all users and idle sessionsThis feature is gated by DBM and cannot be enabled without DBM.
Motivation
https://datadoghq.atlassian.net/browse/DBMON-3997
Additional Notes
Sampled Statements
![image](https://private-user-images.githubusercontent.com/4964070/334867458-009f5883-9a5d-490a-8b06-18f9c9b4c46c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkxODkyOTIsIm5iZiI6MTcxOTE4ODk5MiwicGF0aCI6Ii80OTY0MDcwLzMzNDg2NzQ1OC0wMDlmNTg4My05YTVkLTQ5MGEtOGIwNi0xOGY5YzliNGM0NmMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYyNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MjRUMDAyOTUyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZTg0NWJlOGI4ODhlYTI5MTdhMzFiNWYyZmNjOTNiNzg2YmU3MTFlMjFjMzkzMzRjZmM4ODU1MGViZThhN2JlZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.eF8x15fZ4v7iFHguCvJvtEJD02ODXq_WtcThXmggt68)
![image](https://private-user-images.githubusercontent.com/4964070/334867674-a81c9656-ba08-4ae5-885f-56dc206d6e5d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTkxODkyOTIsIm5iZiI6MTcxOTE4ODk5MiwicGF0aCI6Ii80OTY0MDcwLzMzNDg2NzY3NC1hODFjOTY1Ni1iYTA4LTRhZTUtODg1Zi01NmRjMjA2ZDZlNWQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYyNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MjRUMDAyOTUyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Nzg2NjA2YmVhMGVlN2ZmOGY3NjllNTRmMzk4NzhmYzc4MWQyZDJjYmFlNmRiMDkyMTUyOTEwNWRiNTIyMmQ2ZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.kgz83geGhMzLNZAbfbCi1dFd0MhSS8a7jkRtuyrmtnc)
Explain Plans
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged