-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change the filter query #17575
base: master
Are you sure you want to change the base?
change the filter query #17575
Conversation
Hi @steveny91, unfortunately I don't think we can support changing the Can you elaborate a bit more on the goal you are trying to achieve here, etc.? |
@nhinsch So the problem is this. When I first made this pipeline, I had manually set the source on my pod to collect the logs with source:argo_rollouts, because I was using a demo image that was called argo-demo. But recently I was testing it out with the official argo rollouts image, the short image name there is I wanted to change the source here because I think a large majority of our customers can just collect logs from their argo rollouts instances without needing to manually configure the log source in a containerzied environment (which it's almost exclusively kubernetes based). My other approach was to add in a Thanks for looking into this! |
For the second source, did you use the syntax |
589afe1
@nhinsch Friendly bump on this to see if you have any suggestions here. 🙇 |
@nhinsch Just wanted to give this a bump again. Feel free to contact me over slack if it's easier/ |
Hi Steve, sorry that I missed your messages above. OK, so we don't support having an OR in the source, that is good to know. I think to approve this we would need you to show that changing the source here won't break this integration for existing customers, i.e. that nobody is using this integration yet (or somehow have a plan to get all existing customers to migrate). I suggest that you reach out to the channel #log-management-integrations about this matter as it may require involvement from logs product managers. I also suggest you create a ticket for this proposed change on the logs integrations board so that we can track it better. |
What does this PR do?
container short image name that is automatically assigned as the source.