Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Active Directory - Credential Expiry Event documentation #16158

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

rahulkaukuntla
Copy link
Contributor

@rahulkaukuntla rahulkaukuntla commented Nov 6, 2023

What does this PR do?

Added a blurb under the Events section of the Azure Active Directory integration readme. This blurb discusses credential expiry events.

HOLD FOR GA: cc @rahulkaukuntla

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

Release Checklist

  • This code has automated tests
  • Changes are being deployed behind a feature flag, if applicable
  • Related changes to databases, devops, and/or consul-config have been made, if applicable
  • These changes will work with production-level load
  • I have a plan to verify that these changes are working as expected after deploy
  • I have a plan for how to revert, rollback, or disable these changes if things are not working as expected
  • If PR impacts documentation, docs team has been notified or a card has been created on the documentation triage
  • If PR changes route(s), I have followed the process to update the routes in dogweb and k8s-resources.
  • If the PR adds route(s), I have followed the API Production Readiness Review

See Also: https://github.com/DataDog/devops/wiki/Code-Workflow#deploying-to-production

Security Checklist

This PR creates, modifies, or deletes:

  • API Routes: API routes, parameters and/or user permissions
  • Authentication: Authentication mechanism (SAML, OAuth, password etc.)
  • Credentials: Server side credentials or secrets in configuration/source code
  • Cryptography: Cryptographic directives (encryption, hashing, certificates, signatures, random numbers, etc.)
  • User Data: User input/sensitive content in URL params, logs, error messages, etc.
  • None of the above

Unsure? Have a question? Request a review from @DataDog/security-design-and-guidance!

Additional Notes

Added a blurb under the Events section of the Azure Active Directory integration readme. This blurb discusses credential expiry events.
maycmlee
maycmlee previously approved these changes Nov 6, 2023
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small suggestions, but approving.

pervious to previous
highlight important information

Co-authored-by: May Lee <[email protected]>
@jhgilbert jhgilbert changed the title [HOLD] Azure Active Directory - Credential Expiry Event documentation Azure Active Directory - Credential Expiry Event documentation Nov 14, 2023
@FlorentClarret FlorentClarret merged commit 68b5782 into DataDog:master Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants