Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datadog): allow bundling unspecified events #1702

Closed
wants to merge 3 commits into from

Conversation

gabedos
Copy link
Contributor

@gabedos gabedos commented Feb 14, 2025

What this PR does / why we need it:

This adds an option to the datadog chart to enabled the bundle_unspecified_events setting for the kubernetes apiserver check. When enabled along with unbundleEvents, events that are not specified in collectedEventTypes will be bundled. Related agent config

Note: this is a duplicate of #1683. Just needed some lint fixes.

Special notes for your reviewer:

QA via agent configcheck and noted

=== kubernetes_apiserver check ===
Configuration provider: file
Configuration source: file:/etc/datadog-agent/conf.d/kubernetes_apiserver.yaml
Config for instance ID: kubernetes_apiserver:ad9a65b57804d691
bundle_unspecified_events: true

Checklist

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md

@gabedos gabedos requested a review from a team as a code owner February 14, 2025 15:38
@gabedos gabedos added chart/datadog This issue or pull request is related to the datadog chart enhancement New feature or request labels Feb 14, 2025
@gabedos
Copy link
Contributor Author

gabedos commented Feb 18, 2025

Not exposing this feature publicly yet. Unfinished items internally.

@gabedos gabedos closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog This issue or pull request is related to the datadog chart enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants