[APPSEC-58034] AAP for Go Dockerfiles #30306
Open
+258
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ℹ️ Documentation Team ReviewNo documentation team review is required for this pull request. |
1 task
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 7, 2025
Preview links (active after the
|
eliottness
force-pushed
the
eliottness/dockerfiles
branch
from
dd0ef70 to
00b9317
Compare
eliottness
force-pushed
the
eliottness/exhaustive-doc
branch
from
59b2293 to
582e02e
Compare
1 task
eliottness
force-pushed
the
eliottness/dockerfiles
branch
2 times, most recently
from
aa04abf to
200d242
Compare
eliottness
force-pushed
the
eliottness/exhaustive-doc
branch
from
76d6247 to
964f525
Compare
eliottness
force-pushed
the
eliottness/dockerfiles
branch
from
200d242 to
13f776d
Compare
eliottness
force-pushed
the
eliottness/exhaustive-doc
branch
from
964f525 to
2ce636e
Compare
eliottness
force-pushed
the
eliottness/dockerfiles
branch
from
13f776d to
77c736c
Compare
eliottness
force-pushed
the
eliottness/exhaustive-doc
branch
from
2ce636e to
dec3500
Compare
eliottness
changed the base branch from
eliottness/exhaustive-doc
to
graphite-base/30306
eliottness
force-pushed
the
eliottness/dockerfiles
branch
from
77c736c to
88ed568
Compare
eliottness
force-pushed
the
graphite-base/30306
branch
from
dec3500 to
16655ee
Compare
eliottness
changed the base branch from
graphite-base/30306
to
eliottness/exhaustive-doc
eliottness
changed the base branch from
eliottness/exhaustive-doc
to
graphite-base/30306
eliottness
force-pushed
the
graphite-base/30306
branch
from
16655ee to
bd93b6c
Compare
eliottness
force-pushed
the
eliottness/dockerfiles
branch
from
88ed568 to
80e28a6
Compare
eliottness
changed the base branch from
graphite-base/30306
to
eliottness/exhaustive-doc
Comment on lines
20
to
24
| App and API Protection for Go installation requirements can be abstract and the Go toolchain | ||
| cross-compilation capabilities can make it hard to understand what has to be done precisely. | ||
|
|
||
| In these cases, a more precise way to materialize these examples like a Dockerfile can be interesting. | ||
| The goal of this guide is to be a step-by-step guide to a working Dockerfile, tailor-fitted for your usecase. |
There was a problem hiding this comment.
These feel a little heavy-handed to me. I think they can be simplified a little -- more straight to the point.
There was a problem hiding this comment.
I don't immediately see a suggestion that would fit. Feel free to try it out
content/en/security/application_security/setup/go/dockerfile.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/setup/go/dockerfile.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/setup/go/dockerfile.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/setup/go/dockerfile.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/setup/go/dockerfile.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/setup/go/dockerfile.md
Outdated
Show resolved
Hide resolved
content/en/security/application_security/setup/go/dockerfile.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This is pretty good I think. I think it'd be nice if we can (unsure whether the highlighter supports it?) highlight interesting/different lines in the Dockerfiles after the first one, to make it easier for readers to see where changes were made.
There was a problem hiding this comment.
I did not find any easy way to do that
content/en/security/application_security/setup/go/dockerfile.md
Outdated
Show resolved
Hide resolved
eliottness
commented
Jul 17, 2025
eliottness
force-pushed
the
eliottness/dockerfiles
branch
from
082f608 to
8da53e0
Compare
eliottness
changed the base branch from
eliottness/exhaustive-doc
to
graphite-base/30306
eliottness
force-pushed
the
graphite-base/30306
branch
from
bd93b6c to
8e4c435
Compare
eliottness
force-pushed
the
eliottness/dockerfiles
branch
from
65fabbc to
2d132fc
Compare
eliottness
changed the base branch from
graphite-base/30306
to
eliottness/exhaustive-doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
This PR adds a page on how to design a dockerfile for us in an standard AAP setup.
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes