Skip to content

add ap2 pl documentation #30189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 30, 2025
Merged

add ap2 pl documentation #30189

merged 7 commits into from
Jun 30, 2025

Conversation

nlopez
Copy link
Contributor

@nlopez nlopez commented Jun 27, 2025

What does this PR do? What is the motivation?

Adds PrivateLink info for AP2. I created some additional vars to handle the split between the private DNS names and the product DNS names.

Merge instructions

Merge readiness:

  • Ready for merge

@github-actions github-actions bot added Architecture Everything related to the Doc backend Guide Content impacting a guide labels Jun 27, 2025
Copy link
Contributor

github-actions bot commented Jun 27, 2025

✅ Documentation Team Review

The documentation team has approved this pull request. Thank you for your contribution!

Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@nlopez nlopez force-pushed the nlopez/ap2-pl branch 4 times, most recently from 8bdd76f to 0b8e798 Compare June 30, 2025 18:25
@github-actions github-actions bot removed the Guide Content impacting a guide label Jun 30, 2025
@github-actions github-actions bot added the Guide Content impacting a guide label Jun 30, 2025
@nlopez nlopez force-pushed the nlopez/ap2-pl branch 2 times, most recently from 9127692 to 9e18b95 Compare June 30, 2025 20:25
@hestonhoffman hestonhoffman self-assigned this Jun 30, 2025
@nlopez nlopez marked this pull request as ready for review June 30, 2025 20:43
@nlopez nlopez requested review from a team as code owners June 30, 2025 20:43
@nlopez nlopez requested review from a team and datamarmot as code owners June 30, 2025 20:50
@nlopez nlopez requested review from andrea-mosk and Learza7 June 30, 2025 20:50
Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating this!

@hestonhoffman hestonhoffman removed request for a team and datamarmot June 30, 2025 22:17
@hestonhoffman hestonhoffman merged commit d695ae3 into master Jun 30, 2025
15 checks passed
@hestonhoffman hestonhoffman deleted the nlopez/ap2-pl branch June 30, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend Guide Content impacting a guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants