Skip to content

Remove '$' since one is automatically added when showing bash script #29790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hush-hush
Copy link
Member

What does this PR do? What is the motivation?

Remove '$' since one is automatically added when showing bash script. Adding one manually produce double dollar signs.

Merge instructions

None

Merge readiness:

  • Ready for merge

@hush-hush hush-hush requested a review from a team as a code owner June 6, 2025 16:28
Copy link
Contributor

github-actions bot commented Jun 6, 2025

📝 Documentation Team Review Required

This pull request requires approval from the @DataDog/documentation team before it can be merged.

Please ensure your changes follow our documentation guidelines and wait for a team member to review and approve your changes.

Copy link
Contributor

github-actions bot commented Jun 6, 2025

Preview links (active after the build_preview check completes)

Modified Files

@jhgilbert
Copy link
Contributor

Hi @hush-hush, based on the build preview, this change doesn't seem to have accomplished the goal of automatically adding a $ to the commands. Did you intend to use a code-block shortcode?

Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should do it

Comment on lines +246 to 249
```bash
chown dd-agent:dd-agent datadog-secret-backend
chmod 500 datadog-secret-backend
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```bash
chown dd-agent:dd-agent datadog-secret-backend
chmod 500 datadog-secret-backend
```
```sh
chown dd-agent:dd-agent datadog-secret-backend
chmod 500 datadog-secret-backend
```

@@ -362,8 +362,8 @@ On Linux, the command outputs file mode, owner and group for the executable. On

Example on Linux:

```shell
$> datadog-agent secret
```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```bash
```sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants