-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove warning log when JUnit 4 test method cannot be retrieved #8445
Merged
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/munit-error-log
Feb 25, 2025
Merged
Remove warning log when JUnit 4 test method cannot be retrieved #8445
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/munit-error-log
Feb 25, 2025
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~814405b576, baseline=1.47.0-SNAPSHOT~28c315b990
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1044237
Total [baseline] (10.395 s) : 0, 10394589
Agent [candidate] (1.037 s) : 0, 1036563
Total [candidate] (10.35 s) : 0, 10350152
section appsec
Agent [baseline] (1.186 s) : 0, 1186055
Total [baseline] (10.757 s) : 0, 10756711
Agent [candidate] (1.18 s) : 0, 1179871
Total [candidate] (10.715 s) : 0, 10715167
section iast
Agent [baseline] (1.181 s) : 0, 1180864
Total [baseline] (11.051 s) : 0, 11051102
Agent [candidate] (1.168 s) : 0, 1168443
Total [candidate] (10.984 s) : 0, 10984298
section profiling
Agent [baseline] (1.262 s) : 0, 1261905
Total [baseline] (10.847 s) : 0, 10846877
Agent [candidate] (1.257 s) : 0, 1256760
Total [candidate] (10.811 s) : 0, 10810925
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~814405b576, baseline=1.47.0-SNAPSHOT~28c315b990
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.709 ms) : 0, 720709
BytebuddyAgent [candidate] (714.697 ms) : 0, 714697
GlobalTracer [baseline] (239.902 ms) : 0, 239902
GlobalTracer [candidate] (238.093 ms) : 0, 238093
AppSec [baseline] (55.727 ms) : 0, 55727
AppSec [candidate] (55.329 ms) : 0, 55329
Remote Config [baseline] (688.436 µs) : 0, 688
Remote Config [candidate] (693.017 µs) : 0, 693
Telemetry [baseline] (12.217 ms) : 0, 12217
Telemetry [candidate] (12.826 ms) : 0, 12826
section appsec
BytebuddyAgent [baseline] (738.065 ms) : 0, 738065
BytebuddyAgent [candidate] (732.672 ms) : 0, 732672
GlobalTracer [baseline] (236.762 ms) : 0, 236762
GlobalTracer [candidate] (235.802 ms) : 0, 235802
AppSec [baseline] (176.452 ms) : 0, 176452
AppSec [candidate] (176.902 ms) : 0, 176902
Remote Config [baseline] (652.667 µs) : 0, 653
Remote Config [candidate] (656.674 µs) : 0, 657
Telemetry [baseline] (8.258 ms) : 0, 8258
Telemetry [candidate] (8.245 ms) : 0, 8245
IAST [baseline] (21.814 ms) : 0, 21814
IAST [candidate] (21.492 ms) : 0, 21492
section iast
BytebuddyAgent [baseline] (846.068 ms) : 0, 846068
BytebuddyAgent [candidate] (834.451 ms) : 0, 834451
GlobalTracer [baseline] (230.373 ms) : 0, 230373
GlobalTracer [candidate] (229.573 ms) : 0, 229573
AppSec [baseline] (57.051 ms) : 0, 57051
AppSec [candidate] (57.255 ms) : 0, 57255
Remote Config [baseline] (609.944 µs) : 0, 610
Remote Config [candidate] (620.874 µs) : 0, 621
Telemetry [baseline] (8.695 ms) : 0, 8695
Telemetry [candidate] (8.737 ms) : 0, 8737
IAST [baseline] (22.924 ms) : 0, 22924
IAST [candidate] (22.878 ms) : 0, 22878
section profiling
ProfilingAgent [baseline] (95.947 ms) : 0, 95947
ProfilingAgent [candidate] (95.953 ms) : 0, 95953
BytebuddyAgent [baseline] (711.61 ms) : 0, 711610
BytebuddyAgent [candidate] (707.236 ms) : 0, 707236
GlobalTracer [baseline] (349.015 ms) : 0, 349015
GlobalTracer [candidate] (349.026 ms) : 0, 349026
AppSec [baseline] (55.152 ms) : 0, 55152
AppSec [candidate] (54.638 ms) : 0, 54638
Remote Config [baseline] (663.425 µs) : 0, 663
Remote Config [candidate] (663.846 µs) : 0, 664
Telemetry [baseline] (8.961 ms) : 0, 8961
Telemetry [candidate] (8.913 ms) : 0, 8913
Profiling [baseline] (95.97 ms) : 0, 95970
Profiling [candidate] (95.977 ms) : 0, 95977
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~814405b576, baseline=1.47.0-SNAPSHOT~28c315b990
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1040679
Total [baseline] (8.658 s) : 0, 8658419
Agent [candidate] (1.038 s) : 0, 1037648
Total [candidate] (8.64 s) : 0, 8639806
section iast
Agent [baseline] (1.167 s) : 0, 1167264
Total [baseline] (9.217 s) : 0, 9216735
Agent [candidate] (1.169 s) : 0, 1169211
Total [candidate] (9.265 s) : 0, 9265063
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.171 s) : 0, 1170699
Total [baseline] (9.181 s) : 0, 9180899
Agent [candidate] (1.172 s) : 0, 1171594
Total [candidate] (9.191 s) : 0, 9191004
section iast_TELEMETRY_OFF
Agent [baseline] (1.174 s) : 0, 1174170
Total [baseline] (9.218 s) : 0, 9217533
Agent [candidate] (1.171 s) : 0, 1171432
Total [candidate] (9.225 s) : 0, 9224678
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~814405b576, baseline=1.47.0-SNAPSHOT~28c315b990
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.78 ms) : 0, 718780
BytebuddyAgent [candidate] (716.868 ms) : 0, 716868
GlobalTracer [baseline] (239.507 ms) : 0, 239507
GlobalTracer [candidate] (239.149 ms) : 0, 239149
AppSec [baseline] (55.462 ms) : 0, 55462
AppSec [candidate] (55.409 ms) : 0, 55409
Remote Config [baseline] (702.663 µs) : 0, 703
Remote Config [candidate] (691.304 µs) : 0, 691
Telemetry [baseline] (11.367 ms) : 0, 11367
Telemetry [candidate] (10.613 ms) : 0, 10613
section iast
BytebuddyAgent [baseline] (833.72 ms) : 0, 833720
BytebuddyAgent [candidate] (834.687 ms) : 0, 834687
GlobalTracer [baseline] (229.103 ms) : 0, 229103
GlobalTracer [candidate] (229.554 ms) : 0, 229554
IAST [baseline] (22.909 ms) : 0, 22909
IAST [candidate] (22.937 ms) : 0, 22937
AppSec [baseline] (57.252 ms) : 0, 57252
AppSec [candidate] (57.686 ms) : 0, 57686
Remote Config [baseline] (615.065 µs) : 0, 615
Remote Config [candidate] (617.649 µs) : 0, 618
Telemetry [baseline] (8.774 ms) : 0, 8774
Telemetry [candidate] (8.877 ms) : 0, 8877
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (836.908 ms) : 0, 836908
BytebuddyAgent [candidate] (836.975 ms) : 0, 836975
GlobalTracer [baseline] (229.844 ms) : 0, 229844
GlobalTracer [candidate] (230.333 ms) : 0, 230333
IAST [baseline] (22.849 ms) : 0, 22849
IAST [candidate] (22.906 ms) : 0, 22906
AppSec [baseline] (56.638 ms) : 0, 56638
AppSec [candidate] (57.153 ms) : 0, 57153
Remote Config [baseline] (608.96 µs) : 0, 609
Remote Config [candidate] (614.316 µs) : 0, 614
Telemetry [baseline] (8.783 ms) : 0, 8783
Telemetry [candidate] (8.645 ms) : 0, 8645
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (839.33 ms) : 0, 839330
BytebuddyAgent [candidate] (838.899 ms) : 0, 838899
GlobalTracer [baseline] (230.848 ms) : 0, 230848
GlobalTracer [candidate] (229.308 ms) : 0, 229308
IAST [baseline] (25.701 ms) : 0, 25701
IAST [candidate] (25.413 ms) : 0, 25413
AppSec [baseline] (53.976 ms) : 0, 53976
AppSec [candidate] (53.621 ms) : 0, 53621
Remote Config [baseline] (629.087 µs) : 0, 629
Remote Config [candidate] (610.815 µs) : 0, 611
Telemetry [baseline] (8.671 ms) : 0, 8671
Telemetry [candidate] (8.579 ms) : 0, 8579
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 12 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~814405b576, baseline=1.47.0-SNAPSHOT~28c315b990
dateFormat X
axisFormat %s
section baseline
no_agent (1.355 ms) : 1335, 1374
. : milestone, 1355,
appsec (1.748 ms) : 1723, 1772
. : milestone, 1748,
appsec_no_iast (1.777 ms) : 1753, 1801
. : milestone, 1777,
code_origins (1.704 ms) : 1672, 1737
. : milestone, 1704,
iast (1.503 ms) : 1479, 1527
. : milestone, 1503,
profiling (1.508 ms) : 1484, 1532
. : milestone, 1508,
tracing (1.489 ms) : 1464, 1514
. : milestone, 1489,
section candidate
no_agent (1.372 ms) : 1351, 1392
. : milestone, 1372,
appsec (1.781 ms) : 1757, 1805
. : milestone, 1781,
appsec_no_iast (1.746 ms) : 1721, 1771
. : milestone, 1746,
code_origins (1.692 ms) : 1659, 1726
. : milestone, 1692,
iast (1.519 ms) : 1494, 1543
. : milestone, 1519,
profiling (1.569 ms) : 1544, 1593
. : milestone, 1569,
tracing (1.496 ms) : 1472, 1520
. : milestone, 1496,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~814405b576, baseline=1.47.0-SNAPSHOT~28c315b990
dateFormat X
axisFormat %s
section baseline
no_agent (380.96 µs) : 360, 402
. : milestone, 381,
iast (509.653 µs) : 487, 532
. : milestone, 510,
iast_FULL (730.735 µs) : 709, 753
. : milestone, 731,
iast_GLOBAL (557.251 µs) : 536, 579
. : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (513.278 µs) : 492, 535
. : milestone, 513,
iast_INACTIVE (469.636 µs) : 448, 491
. : milestone, 470,
iast_TELEMETRY_OFF (498.379 µs) : 476, 520
. : milestone, 498,
tracing (455.683 µs) : 434, 477
. : milestone, 456,
section candidate
no_agent (392.495 µs) : 373, 412
. : milestone, 392,
iast (513.536 µs) : 492, 536
. : milestone, 514,
iast_FULL (724.449 µs) : 703, 746
. : milestone, 724,
iast_GLOBAL (549.069 µs) : 528, 571
. : milestone, 549,
iast_HARDCODED_SECRET_DISABLED (513.172 µs) : 490, 536
. : milestone, 513,
iast_INACTIVE (462.681 µs) : 442, 484
. : milestone, 463,
iast_TELEMETRY_OFF (499.58 µs) : 476, 523
. : milestone, 500,
tracing (456.782 µs) : 436, 478
. : milestone, 457,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~814405b576, baseline=1.47.0-SNAPSHOT~28c315b990
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (2.365 ms) : 2321, 2408
. : milestone, 2365,
iast (2.116 ms) : 2061, 2171
. : milestone, 2116,
iast_GLOBAL (2.153 ms) : 2097, 2209
. : milestone, 2153,
profiling (1.958 ms) : 1914, 2001
. : milestone, 1958,
tracing (1.946 ms) : 1904, 1989
. : milestone, 1946,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (2.369 ms) : 2326, 2413
. : milestone, 2369,
iast (2.119 ms) : 2063, 2174
. : milestone, 2119,
iast_GLOBAL (2.157 ms) : 2101, 2212
. : milestone, 2157,
profiling (1.98 ms) : 1936, 2024
. : milestone, 1980,
tracing (1.95 ms) : 1908, 1992
. : milestone, 1950,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~814405b576, baseline=1.47.0-SNAPSHOT~28c315b990
dateFormat X
axisFormat %s
section baseline
no_agent (14.969 s) : 14969000, 14969000
. : milestone, 14969000,
appsec (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
iast (18.843 s) : 18843000, 18843000
. : milestone, 18843000,
iast_GLOBAL (17.666 s) : 17666000, 17666000
. : milestone, 17666000,
profiling (15.23 s) : 15230000, 15230000
. : milestone, 15230000,
tracing (15.085 s) : 15085000, 15085000
. : milestone, 15085000,
section candidate
no_agent (14.73 s) : 14730000, 14730000
. : milestone, 14730000,
appsec (15.128 s) : 15128000, 15128000
. : milestone, 15128000,
iast (18.973 s) : 18973000, 18973000
. : milestone, 18973000,
iast_GLOBAL (17.975 s) : 17975000, 17975000
. : milestone, 17975000,
profiling (15.089 s) : 15089000, 15089000
. : milestone, 15089000,
tracing (14.985 s) : 14985000, 14985000
. : milestone, 14985000,
|
daniel-mohedano
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Fixes #8441
Additional Notes
With some JUnit4-based frameworks (such as Scala MUnit) it is expected that the tracer cannot determine test case method (with Scala MUnit the necessary information is not available at runtime).
Therefore we should not be reporting this as a warning, and clutter the users' logs.
It will still be reported with debug logging level and will be available in telemetry logs.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]