Skip to content

fix(trace-exporter): add error handling when releasing handles in ErrorHandle, TraceExporter, and TraceExporterConfiguration #7061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

fix(trace-exporter): add error handling when releasing handles in ErrorHandle, TraceExporter, and TraceExporterConfiguration #7061

merged 1 commit into from
Jun 5, 2025

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Jun 4, 2025 •
edited
Loading

Summary of changes

Follow up of #6314 (comment)

Reason for change

These exceptions should never happen but given we are overly cautious about not breaking the customer app, I wrapped all handle releases.

Implementation details

try-catch

Test coverage

None

Other details

@ganeshnj ganeshnj requested a review from a team as a code owner June 4, 2025 14:24
@ganeshnj ganeshnj mentioned this pull request Jun 4, 2025
Merged
@github-actions github-actions bot added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Jun 4, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 4, 2025 •
edited
Loading

Datadog Report

All test runs ff45ccd 🔗

✅ 2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 0 0 0 246986 2454 15h 16m 18.35s Link
exploration_tests 0 0 0 22085 3 2m 16.59s Link

@andrewlock
Copy link
Member

andrewlock commented Jun 4, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7061) - mean (72ms)  : 69, 76
     .   : milestone, 72,
    master - mean (74ms)  : 69, 78
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (7061) - mean (1,050ms)  : 1025, 1076
     .   : milestone, 1050,
    master - mean (1,054ms)  : 1034, 1074
     .   : milestone, 1054,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7061) - mean (109ms)  : 106, 112
     .   : milestone, 109,
    master - mean (110ms)  : 107, 113
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (7061) - mean (729ms)  : 712, 746
     .   : milestone, 729,
    master - mean (736ms)  : 713, 758
     .   : milestone, 736,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7061) - mean (95ms)  : 91, 98
     .   : milestone, 95,
    master - mean (96ms)  : 94, 99
     .   : milestone, 96,

    section CallTarget+Inlining+NGEN
    This PR (7061) - mean (698ms)  : 670, 726
     .   : milestone, 698,
    master - mean (701ms)  : 672, 729
     .   : milestone, 701,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7061) - mean (190ms)  : 185, 194
     .   : milestone, 190,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (7061) - mean (1,165ms)  : 1145, 1185
     .   : milestone, 1165,
    master - mean (1,164ms)  : 1143, 1185
     .   : milestone, 1164,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7061) - mean (269ms)  : 266, 272
     .   : milestone, 269,
    master - mean (270ms)  : 266, 273
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (7061) - mean (928ms)  : 915, 940
     .   : milestone, 928,
    master - mean (932ms)  : 919, 944
     .   : milestone, 932,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7061) - mean (262ms)  : 259, 264
     .   : milestone, 262,
    master - mean (263ms)  : 258, 267
     .   : milestone, 263,

    section CallTarget+Inlining+NGEN
    This PR (7061) - mean (927ms)  : 912, 943
     .   : milestone, 927,
    master - mean (934ms)  : 915, 954
     .   : milestone, 934,
Loading

@pr-commenter
Copy link

pr-commenter bot commented Jun 4, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7061 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.268
  • 3 benchmarks have fewer allocations
  • 4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7061

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.09 KB 6.12 KB 36 B 0.59%

Fewer allocations 🎉 in #7061

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0 5.58 KB 5.51 KB -64 B -1.15%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.2μs 59.7ns 322ns 0 0 0 5.58 KB
master StartStopWithChild netcoreapp3.1 14.1μs 67.5ns 286ns 0 0 0 5.75 KB
master StartStopWithChild net472 22.1μs 119ns 651ns 1.03 0.411 0.103 6.09 KB
#7061 StartStopWithChild net6.0 10.8μs 60.6ns 424ns 0 0 0 5.51 KB
#7061 StartStopWithChild netcoreapp3.1 13.7μs 69.1ns 309ns 0 0 0 5.75 KB
#7061 StartStopWithChild net472 22μs 122ns 782ns 1.06 0.317 0.106 6.12 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 927μs 26.6ns 103ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 404ns 1.56μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.25ms 357ns 1.38μs 0 0 0 3.33 KB
#7061 WriteAndFlushEnrichedTraces net6.0 922μs 120ns 451ns 0 0 0 2.72 KB
#7061 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 135ns 525ns 0 0 0 2.7 KB
#7061 WriteAndFlushEnrichedTraces net472 1.28ms 1.42μs 5.48μs 0 0 0 3.33 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 331μs 1.76μs 8.42μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 510μs 1.45μs 5.61μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 436μs 119ns 460ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 338μs 1.76μs 8.8μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 495μs 987ns 3.56μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 446μs 106ns 412ns 36.6 2.16 0 239.87 KB
master ObjectExtractorSimpleBody net6.0 311ns 1.77ns 12.3ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 409ns 1.93ns 8.2ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 303ns 0.175ns 0.676ns 0.0442 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.52μs 29.5ns 110ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.76μs 36.2ns 140ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.66μs 0.89ns 3.33ns 0.599 0 0 3.8 KB
#7061 AllCycleSimpleBody net6.0 334μs 1.09μs 4.2μs 0 0 0 197.41 KB
#7061 AllCycleSimpleBody netcoreapp3.1 498μs 1.75μs 6.76μs 0 0 0 205.17 KB
#7061 AllCycleSimpleBody net472 439μs 159ns 615ns 36.6 2.16 0 236.95 KB
#7061 AllCycleMoreComplexBody net6.0 339μs 660ns 2.56μs 0 0 0 200.92 KB
#7061 AllCycleMoreComplexBody netcoreapp3.1 485μs 1.93μs 7.49μs 0 0 0 208.58 KB
#7061 AllCycleMoreComplexBody net472 448μs 99.4ns 385ns 37.9 2.23 0 240.46 KB
#7061 ObjectExtractorSimpleBody net6.0 312ns 1.57ns 6.85ns 0 0 0 280 B
#7061 ObjectExtractorSimpleBody netcoreapp3.1 400ns 2.04ns 9.35ns 0 0 0 272 B
#7061 ObjectExtractorSimpleBody net472 303ns 0.0589ns 0.228ns 0.0442 0 0 281 B
#7061 ObjectExtractorMoreComplexBody net6.0 6.41μs 27.2ns 105ns 0 0 0 3.78 KB
#7061 ObjectExtractorMoreComplexBody netcoreapp3.1 7.75μs 29.8ns 115ns 0 0 0 3.69 KB
#7061 ObjectExtractorMoreComplexBody net472 6.9μs 6.62ns 25.6ns 0.584 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7061

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net6.0 2.16 KB 2.15 KB -11 B -0.51%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 73.3μs 263ns 984ns 0 0 0 32.41 KB
master EncodeArgs netcoreapp3.1 95.7μs 36.2ns 130ns 0 0 0 32.4 KB
master EncodeArgs net472 107μs 17.6ns 65.8ns 4.82 0 0 32.51 KB
master EncodeLegacyArgs net6.0 143μs 122ns 472ns 0 0 0 2.16 KB
master EncodeLegacyArgs netcoreapp3.1 197μs 42.5ns 147ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 66.8ns 250ns 0 0 0 2.16 KB
#7061 EncodeArgs net6.0 73.5μs 10.7ns 41.3ns 0 0 0 32.41 KB
#7061 EncodeArgs netcoreapp3.1 94.1μs 264ns 1.02μs 0 0 0 32.4 KB
#7061 EncodeArgs net472 105μs 17.2ns 64.4ns 4.72 0 0 32.51 KB
#7061 EncodeLegacyArgs net6.0 146μs 68.5ns 265ns 0 0 0 2.15 KB
#7061 EncodeLegacyArgs netcoreapp3.1 195μs 137ns 511ns 0 0 0 2.14 KB
#7061 EncodeLegacyArgs net472 261μs 36.2ns 131ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7061

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑net472 2.28 KB 2.3 KB 12 B 0.53%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 271μs 133ns 499ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 294μs 264ns 989ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 307μs 38.1ns 147ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 181μs 80.1ns 300ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 198μs 104ns 404ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 207μs 45.3ns 169ns 0 0 0 2.28 KB
#7061 RunWafRealisticBenchmark net6.0 271μs 39.8ns 149ns 0 0 0 4.55 KB
#7061 RunWafRealisticBenchmark netcoreapp3.1 297μs 80.3ns 278ns 0 0 0 4.48 KB
#7061 RunWafRealisticBenchmark net472 307μs 25.5ns 95.3ns 0 0 0 4.66 KB
#7061 RunWafRealisticBenchmarkWithAttack net6.0 183μs 22.2ns 76.8ns 0 0 0 2.24 KB
#7061 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 193μs 73.9ns 266ns 0 0 0 2.22 KB
#7061 RunWafRealisticBenchmarkWithAttack net472 208μs 45.8ns 177ns 0 0 0 2.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.1μs 29ns 104ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 69.9μs 118ns 440ns 0 0 0 17.42 KB
master SendRequest net472 0.0171ns 0.00147ns 0.00551ns 0 0 0 0 b
#7061 SendRequest net6.0 61μs 68.4ns 247ns 0 0 0 14.53 KB
#7061 SendRequest netcoreapp3.1 70.7μs 101ns 378ns 0 0 0 17.42 KB
#7061 SendRequest net472 0.0199ns 0.00208ns 0.00805ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 645μs 512ns 1.98μs 0 0 0 41.73 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 631μs 1.67μs 6.67μs 0 0 0 41.89 KB
master WriteAndFlushEnrichedTraces net472 923μs 1.93μs 7.2μs 4.46 0 0 55.75 KB
#7061 WriteAndFlushEnrichedTraces net6.0 654μs 562ns 2.18μs 0 0 0 41.73 KB
#7061 WriteAndFlushEnrichedTraces netcoreapp3.1 652μs 1.56μs 5.84μs 0 0 0 42.01 KB
#7061 WriteAndFlushEnrichedTraces net472 889μs 4.03μs 15.6μs 8.33 0 0 55.98 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.99μs 10.2ns 46.8ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.53μs 3.43ns 13.3ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.7μs 2.41ns 9.34ns 0.147 0.0134 0 995 B
#7061 ExecuteNonQuery net6.0 1.95μs 6.97ns 27ns 0 0 0 1.03 KB
#7061 ExecuteNonQuery netcoreapp3.1 2.54μs 11.7ns 46.8ns 0 0 0 1.02 KB
#7061 ExecuteNonQuery net472 2.71μs 3.89ns 15.1ns 0.148 0.0135 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.83μs 5.85ns 22.7ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.3μs 11.8ns 56.6ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.55μs 3.05ns 11.8ns 0.159 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.81μs 3.89ns 14.5ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.35μs 7.26ns 28.1ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.84μs 3.19ns 12.4ns 0.169 0 0 1.11 KB
#7061 CallElasticsearch net6.0 1.8μs 7.12ns 26.6ns 0 0 0 1.04 KB
#7061 CallElasticsearch netcoreapp3.1 2.23μs 10.7ns 41.5ns 0 0 0 1.04 KB
#7061 CallElasticsearch net472 3.91μs 2.38ns 9.2ns 0.156 0 0 1.05 KB
#7061 CallElasticsearchAsync net6.0 1.83μs 4.71ns 18.2ns 0 0 0 1.02 KB
#7061 CallElasticsearchAsync netcoreapp3.1 2.43μs 9.15ns 35.5ns 0 0 0 1.09 KB
#7061 CallElasticsearchAsync net472 4.19μs 3.47ns 13.4ns 0.166 0 0 1.11 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.78μs 9.27ns 43.5ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.29μs 7.45ns 25.8ns 0 0 0 960 B
master ExecuteAsync net472 2.58μs 1.78ns 6.88ns 0.143 0 0 923 B
#7061 ExecuteAsync net6.0 1.86μs 9.12ns 40.8ns 0 0 0 960 B
#7061 ExecuteAsync netcoreapp3.1 2.31μs 11.5ns 50.2ns 0 0 0 960 B
#7061 ExecuteAsync net472 2.62μs 4.95ns 19.2ns 0.145 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7.1μs 10.4ns 39ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.69μs 14.1ns 54.6ns 0 0 0 2.9 KB
master SendAsync net472 12.5μs 10.3ns 38.5ns 0.498 0 0 3.19 KB
#7061 SendAsync net6.0 6.99μs 5.05ns 19.6ns 0 0 0 2.37 KB
#7061 SendAsync netcoreapp3.1 8.47μs 40.2ns 156ns 0 0 0 2.9 KB
#7061 SendAsync net472 12.6μs 14.8ns 57.1ns 0.505 0 0 3.19 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7061

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 1.359 413,700.00 562,100.00
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 1.184 458,300.00 542,450.00

More allocations ⚠️ in #7061

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 259.96 KB 275.98 KB 16.02 KB 6.16%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 274.93 KB 276.92 KB 1.99 KB 0.72%

Fewer allocations 🎉 in #7061

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 286.72 KB 274.1 KB -12.62 KB -4.40%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.6μs 212ns 1.6μs 0 0 0 43.83 KB
master StringConcatBenchmark netcoreapp3.1 47.2μs 224ns 838ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 56.8μs 259ns 968ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 458μs 1.08μs 3.89μs 0 0 0 259.96 KB
master StringConcatAspectBenchmark netcoreapp3.1 447μs 6.44μs 63.7μs 0 0 0 274.93 KB
master StringConcatAspectBenchmark net472 410μs 2.07μs 9.27μs 0 0 0 286.72 KB
#7061 StringConcatBenchmark net6.0 46.2μs 160ns 575ns 0 0 0 43.82 KB
#7061 StringConcatBenchmark netcoreapp3.1 49.9μs 290ns 2.23μs 0 0 0 42.68 KB
#7061 StringConcatBenchmark net472 57.8μs 286ns 1.25μs 0 0 0 57.34 KB
#7061 StringConcatAspectBenchmark net6.0 547μs 2.5μs 9.34μs 0 0 0 275.98 KB
#7061 StringConcatAspectBenchmark netcoreapp3.1 560μs 2.79μs 12.5μs 0 0 0 276.92 KB
#7061 StringConcatAspectBenchmark net472 405μs 2.23μs 12.8μs 0 0 0 274.1 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 2.6ns 10.1ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.44μs 4.38ns 17ns 0 0 0 1.76 KB
master EnrichedLog net472 4.05μs 4.83ns 18.7ns 0.265 0 0 1.69 KB
#7061 EnrichedLog net6.0 2.59μs 10.5ns 40.6ns 0 0 0 1.76 KB
#7061 EnrichedLog netcoreapp3.1 3.51μs 12.6ns 48.9ns 0 0 0 1.76 KB
#7061 EnrichedLog net472 3.95μs 4.52ns 17.5ns 0.257 0 0 1.69 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 145ns 563ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 126μs 330ns 1.24μs 0 0 0 4.37 KB
master EnrichedLog net472 167μs 161ns 603ns 0 0 0 4.57 KB
#7061 EnrichedLog net6.0 123μs 172ns 642ns 0 0 0 4.37 KB
#7061 EnrichedLog netcoreapp3.1 129μs 198ns 739ns 0 0 0 4.37 KB
#7061 EnrichedLog net472 168μs 72.9ns 273ns 0 0 0 4.57 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.94μs 19.3ns 74.6ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.77μs 22.2ns 79.9ns 0 0 0 2.32 KB
master EnrichedLog net472 7.45μs 8.04ns 31.1ns 0.335 0 0 2.14 KB
#7061 EnrichedLog net6.0 4.85μs 9.47ns 35.4ns 0 0 0 2.32 KB
#7061 EnrichedLog netcoreapp3.1 6.84μs 22.6ns 87.4ns 0 0 0 2.32 KB
#7061 EnrichedLog net472 7.58μs 7.97ns 30.9ns 0.303 0 0 2.14 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.04μs 10.5ns 49.4ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.53μs 11.8ns 47.4ns 0 0 0 1.21 KB
master SendReceive net472 3.28μs 2.71ns 10.5ns 0.178 0 0 1.21 KB
#7061 SendReceive net6.0 2.02μs 7.42ns 27.8ns 0 0 0 1.21 KB
#7061 SendReceive netcoreapp3.1 2.5μs 8.67ns 33.6ns 0 0 0 1.21 KB
#7061 SendReceive net472 3.08μs 1.81ns 6.77ns 0.185 0 0 1.21 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.18μs 0.92ns 3.44ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.64μs 23ns 89.3ns 0 0 0 1.69 KB
master EnrichedLog net472 6.67μs 7.28ns 27.3ns 0.298 0 0 2.08 KB
#7061 EnrichedLog net6.0 4.2μs 14.8ns 57.4ns 0 0 0 1.64 KB
#7061 EnrichedLog netcoreapp3.1 5.82μs 14.4ns 55.8ns 0 0 0 1.69 KB
#7061 EnrichedLog net472 6.54μs 3.03ns 10.9ns 0.327 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 751ns 3.97ns 22.4ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 953ns 4.42ns 17.7ns 0 0 0 584 B
master StartFinishSpan net472 914ns 0.809ns 3.13ns 0.0912 0 0 586 B
master StartFinishScope net6.0 918ns 0.479ns 1.73ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.15μs 6.24ns 34.2ns 0 0 0 704 B
master StartFinishScope net472 1.09μs 0.174ns 0.652ns 0.104 0 0 666 B
#7061 StartFinishSpan net6.0 754ns 3.72ns 15.8ns 0 0 0 584 B
#7061 StartFinishSpan netcoreapp3.1 952ns 5.2ns 19.5ns 0 0 0 584 B
#7061 StartFinishSpan net472 914ns 0.0866ns 0.324ns 0.0916 0 0 586 B
#7061 StartFinishScope net6.0 914ns 3.34ns 12.5ns 0 0 0 704 B
#7061 StartFinishScope netcoreapp3.1 1.18μs 5.78ns 24.5ns 0 0 0 704 B
#7061 StartFinishScope net472 1.11μs 0.609ns 2.36ns 0.104 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.02μs 5.36ns 26.8ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.38μs 2.28ns 8.82ns 0 0 0 704 B
master RunOnMethodBegin net472 1.36μs 0.141ns 0.544ns 0.102 0 0 666 B
#7061 RunOnMethodBegin net6.0 1μs 4.78ns 20.3ns 0 0 0 704 B
#7061 RunOnMethodBegin netcoreapp3.1 1.34μs 5.88ns 22.8ns 0 0 0 704 B
#7061 RunOnMethodBegin net472 1.4μs 1.62ns 6.27ns 0.104 0 0 666 B

@ganeshnj ganeshnj changed the title fix: add error handling when releasing handles in ErrorHandle, TraceExporter, and TraceExporterConfiguration fix(trace-exporter): add error handling when releasing handles in ErrorHandle, TraceExporter, and TraceExporterConfiguration Jun 4, 2025
@ganeshnj ganeshnj force-pushed the ganeshnj/chore/try-catch-drops branch from 6f3ccc3 to ff45ccd Compare June 4, 2025 20:26
@ganeshnj ganeshnj merged commit c2267cf into master Jun 5, 2025
130 of 132 checks passed
@ganeshnj ganeshnj deleted the ganeshnj/chore/try-catch-drops branch June 5, 2025 07:59
@github-actions github-actions bot added this to the vNext-v3 milestone Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees
No one assigned
Labels
area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations)
Projects
None yet
Milestone
3.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ganeshnj @andrewlock