Improve the 'Failed to create source' error message to include some hints as to what failed

[erulabs]

What does this PR do?

Improves the 'Failed to create source' error message to include some hints as to what failed

Motivation

This is very difficult to debug in large cluster! Something is failing too parse, but I do not know what!

Describe how you validated your changes

It's valid go! I have not run local tests, still getting up to speed on this codebase

Possible Drawbacks / Trade-offs

Perhaps theres a better / more standard way of annotating the Error log?

[soberpeach]

Hi! This is a known issue, I've merged a PR that fixes this issue for the next release here: #32976.

[erulabs]

Heya @soberpeach - thank you (again!). I was about to rebase this on your changes, perhaps we could improve the failed to create source message further with ddLog.Errorf("Failed to create source for %q (provider: '%s', serviceID: '%s', source: '%s'): %v", cfg.Config.Name, cfg.Config.Provider, cfg.Config.ServiceID, cfg.Config.Source, err).

Happy to close this tho assuming you're confident about your change. Seems like these failed to parse config messages ought to be as verbose as possible since it's going to fall on the attentive sysadmin to resolve their own config in the case of failure.

[erulabs]

I rebased the commit so if you do decide to improve that error anyways it'd be as easy as merging 👯

Thanks again!

[soberpeach]

Thanks! I don't expect this to be much of an issue anymore, but I'll definitely come back to this if people end up hitting it in the future.