[afpacket] Fix race with Close() seen in CI

[pimlu]

Sister PR in gopacket: Separate Stop() from Close()

What does this PR do?

Unfortunately there's a race I missed in Allow Close() to cancel ZeroCopyReadPacketData: The []byte returned by ZeroCopyReadPacketData() is mmapped, not garbage collected, so it's unsafe to Close() a TPacket while that's still in use.

Rarely, tests would segfault after it tries to read from the unmapped page.

Motivation

Fix CI

Describe how you validated your changes

Run TestTCPCollectionDisabled 500 times, it should not segfault:

DD_REMOTE_CONFIGURATION_ENABLED=false sudo -E go test -race -count 500 -tags=linux,linux_bpf,npm,process,test ./pkg/network/tracer -v --run TestTracerSuite/eBPFless/TestTCPCollectionDisabled

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55193531 --os-family=ubuntu

Note: This applies to commit 27738a3

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor de38a6b06ee71cc6464eba2fc53badfa1463e69c

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-arm64-deb	0.00MB	✅	861.55MB	861.54MB	0.50MB
datadog-agent-aarch64-rpm	0.00MB	✅	871.27MB	871.27MB	0.50MB
datadog-agent-amd64-deb	0.00MB	✅	873.67MB	873.67MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	59.10MB	59.10MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	59.18MB	59.18MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	59.18MB	59.18MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	56.57MB	56.57MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	446.05MB	446.05MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	86.48MB	86.48MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	86.55MB	86.55MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	86.55MB	86.55MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	82.74MB	82.74MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	82.81MB	82.81MB	0.50MB
datadog-agent-x86_64-rpm	-0.00MB	✅	883.41MB	883.41MB	0.50MB
datadog-agent-x86_64-suse	-0.00MB	✅	883.41MB	883.41MB	0.50MB

Decision

✅ Passed

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: efaf0695-eb67-4398-ae86-f8d7cfb8f606

Baseline: de38a6b
Comparison: 27738a3
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_idle	memory utilization	+0.43	[+0.39, +0.47]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.40	[-0.38, +1.17]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.32	[+0.26, +0.38]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.27	[-0.61, +1.14]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.26	[+0.18, +0.33]	1	Logs
➖	file_tree	memory utilization	+0.25	[+0.19, +0.31]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.08	[-0.71, +0.87]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.05	[-0.42, +0.52]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.02	[-0.72, +0.77]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.01	[-0.83, +0.86]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.26, +0.27]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.00	[-0.63, +0.64]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.02]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.03	[-0.91, +0.84]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.17	[-1.04, +0.70]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.63	[-3.66, +2.40]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

[agent-platform-auto-pr]

Static quality checks ✅

Please find below the results from static quality gates

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	844.52MiB	858.45MiB	203.58MiB	214.3MiB
✅	static_quality_gate_docker_agent_amd64	929.33MiB	942.69MiB	310.72MiB	321.56MiB

[pimlu]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2025-02-06 22:23:43 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

---

2025-02-06 23:21:11 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 29m.

---

2025-02-06 23:52:14 UTC ℹ️ MergeQueue: This merge request was merged