Added basic checks to ensure the correct version of Docker Compose is installed. #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safety check to ensure the correct version of docker compose is installed
|
Hey thanks for the PR. |
edznux-dd
requested changes
Dec 26, 2023
even better safety check. Co-authored-by: Edouard Schweisguth <[email protected]>
d0g0x01
reviewed
Feb 21, 2024
| @@ -31,6 +31,12 @@ check_docker() { | |||
| exit 1 | |||
| fi | |||
|
|
|||
| if ! [ "$(docker compose version | grep '^Docker Compose version v2')" ]; then | |||
There was a problem hiding this comment.
what about when v3 is released?
|
Hey, we have reworked a bit the Makefile and launch script to be way more user friendly as part of #200! It is available as part of the pre-release already but we will also ship a "real version" soon. Closing that PR, thanks for the work though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safety check to ensure the correct version of docker compose is installed. Used the existing docker detection logic to ensure that the correct version is found.