Fix some bugs, correct natural ordering, slicer test and aggregate and update tests #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct bug due incorrect call of Workspace module which is imported relatively.
Fix natural_order
Fix natural order
Remove amount_sum aggreagate check from test_aggregates and remove dpreciated exception of the test Fix metadata/base/localized setattr error by assigning directly. iRemove python 3.3 test and add 3.4 to 3.7 tests
ThamaluM
changed the title
|
Fixed natural ordering |
|
I closed this by accident so I reopen it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct bug due incorrect call of Workspace module which is imported relatively.