Fix translate cube #462
Open
Fix translate cube #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 19, 2018 13:18
* The assertion can now take a type or a tuple of type in parameter. * Fix wrong displayed error message in function assert_all_instances. * Update docstring.
jjmontesl
reviewed
Jan 5, 2019
| @@ -267,6 +273,7 @@ def __init__(self, name, dimensions=None, measures=None, aggregates=None, | |||
|
|
|||
| # We don't need to access details by name | |||
| details = details or [] | |||
| measures = _replace_all_dict_by_instance(measures, Attribute) | |||
There was a problem hiding this comment.
Shall be details = _replace...?
jjmontesl
reviewed
Jan 5, 2019
| @@ -258,6 +263,7 @@ def __init__(self, name, dimensions=None, measures=None, aggregates=None, | |||
| # Aggregates | |||
| # | |||
| aggregates = aggregates or [] | |||
| measures = _replace_all_dict_by_instance(measures, MeasureAggregate) | |||
There was a problem hiding this comment.
Shall be aggregates = _replace...?
|
I am a bit unsure about this PR. Does it aim to restore l18n functionality? Anyway, seems there are some issues, please have a looks at comments. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
tests.test_localization.LocalizationTestCase.test_translate_cubefails because the class Cube is now of immutable.