-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AN-370] When converting submission to a TSV, access data by the headers #5230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to test under the specified conditions, but the code looks good to me. I added some optional comments for consideration.
Co-authored-by: Kevin Marete <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies. I just saw this.
|
Jira Ticket: https://broadworkbench.atlassian.net/browse/AN-370
Summary of changes:
What
Iteration on this PR that added 'N/A' as a the cost when none existed, this makes sure all the columns are in the same order when downloading submission details by accessing the columns by the header names
Why
So that the columns are consistent when downloading submission details
Testing strategy
I tested by replacing
await Workspaces(signal).workspace(namespace, name).submission(submissionId).get()
with a truncated version of the response in the affected user's workspace (shown below)
Then going to the job history page, clicking on a workflow run and checking that the submission downloaded with the correct columns (includes a cost column, null values are N/A and the values are in the correct columns)