TSPS-404 Throw correct exception for Sam user not found #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dvoet
approved these changes
Feb 5, 2025
pshapiro4broad
approved these changes
Feb 13, 2025
Comment on lines
66
to
71
| } catch (final ApiException e) { | ||
| if (e.getCode() == HttpStatus.NOT_FOUND.value()) { | ||
| if (e.getCode() == HttpStatus.NOT_FOUND.value() | ||
| || e.getCode() == HttpStatus.FORBIDDEN.value()) { | ||
| throw new UnauthorizedException("User not found", e); | ||
| } else { | ||
| throw new InternalServerErrorException(e); |
There was a problem hiding this comment.
It seems odd to have an exception that contains a http status and then use it to map to a different http status. Another approach would be to map the ApiException's status directly to the new exception value
throw new ErrorReportException(e, HttpStatus.valueOf(e.getCode())) {};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teaspoons uses TCL's SamUserFactory to check that the user is registered in Sam.
However, if a user is not registered in Sam/Terra, TCL is currently throwing an InternalServerErrorException that results in a 500 response, with the error message stating that the user was not found in Sam and an error code of 403 (FORBIDDEN). That's because TCL expects Sam to return a 404 (NOT_FOUND), so it doesn't properly handle the 403 that Sam returns in this case .
This PR updates the logic so that TCL treats both a 404 and a 403 as "User not found".
Teaspoons Jira ticket: https://broadworkbench.atlassian.net/browse/TSPS-404