Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://broadworkbench.atlassian.net/browse/[ticket_number]
Summary of changes
Updates to support Galaxy 25.0 release.
What
As discussed over Zoom and Slack with @lucymcnatt & @LizBaldo a couple of months ago, this release of Galaxy splits up the installation process in 2 steps: (1) install cluster-wide dependencies (via galaxy-deps chart), and (2) installs Galaxy via the galaxykubeman (GKM) chart as before.
The changes in the PR definitely need a close review and very likely modifications by someone familiar with Leo (and Scala), but I figured this would get us started.
Why
Uninstalling Galaxy when one chart managed Galaxy and all its dependencies would occasionally cause issues during uninstallation (eg, database operator gets uninstalled before the database does, leaving the uninstallation process stuck). Splitting it up into two charts solves that issue.
Testing these changes
What to test
Who tested and where
I've not tested anything via Leo but have tested the installation on GKE of the galaxy-deps and GKM charts, which work as expected.
jenkins retest
orjenkins multi-test
.