Run tests on windows and mac #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohithg
force-pushed
the
mohithg/try-windows
branch
from
a895c79
to
a4b5433
Compare
mohithg
force-pushed
the
mohithg/try-windows
branch
from
a4b5433
to
27d436b
Compare
mohithg
force-pushed
the
mohithg/try-windows
branch
5 times, most recently
from
ce574f4
to
379ffa7
Compare
mohithg
force-pushed
the
mohithg/try-windows
branch
2 times, most recently
from
06f3ef4
to
54ca80c
Compare
mohithg
force-pushed
the
mohithg/try-windows
branch
from
54ca80c
to
a773bc5
Compare
mohithg
force-pushed
the
mohithg/try-windows
branch
2 times, most recently
from
ed6c4f7
to
677e6c5
Compare
mohithg
force-pushed
the
mohithg/try-windows
branch
from
677e6c5
to
05f1325
Compare
mohithg
force-pushed
the
mohithg/try-windows
branch
6 times, most recently
from
ccf0f60
to
346e22b
Compare
mohithg
force-pushed
the
mohithg/try-windows
branch
from
346e22b
to
f08eabd
Compare
guysmoilov
reviewed
Nov 14, 2021
fds/utils.py
Outdated
Comment on lines
35
to
37
| stdout, stderr = output.communicate() | ||
| sys.stdout.write(convert_bytes_to_string(stdout)) | ||
| sys.stderr.write(convert_bytes_to_string(stderr)) |
There was a problem hiding this comment.
The problem here is that the streams won't be outputted in correct order.
If there's an error written to stderr in the middle of output, it will still appear in the end in this way, and cause confusion.
Why not pass a splitting stream to stdout and stderr, which both stores the outputs in byte buffers, and writes them to sys.stdout and sys.stderr ?
Example: https://stackoverflow.com/a/616686
There was a problem hiding this comment.
Oh yeah, I forgot to do this part, We originally were doing it, I changed it so that it works in windows too
mohithg
force-pushed
the
mohithg/try-windows
branch
from
6edbce1
to
828cc3a
Compare
mohithg
force-pushed
the
mohithg/try-windows
branch
from
83a0de5
to
96a55fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.