Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multline #48

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add support for multline #48

wants to merge 11 commits into from

Conversation

notjagan
Copy link

@notjagan notjagan commented Aug 11, 2016

This is simply an intermediate pull request for before #46 is merged. I do not expect this to pass the checks because it will once this is merged in and the other request is merged in since the other request fixes the checks itself.

@physikerwelt
Copy link
Member

@notjagan Why don't you focus on getting #46 straight first?

@physikerwelt
Copy link
Member

please rebase

@HowardCohl
Copy link
Member

@notjagan Have you rebased yet?

@notjagan
Copy link
Author

notjagan commented Aug 22, 2016

@physikerwelt I have now merged the branch to reflect the changes made in #46 and updated the code to work with pegJS 0.10.0. If/when this gets merged in, I will then create a pull request to similarly add \begin{split}.

@HowardCohl
Copy link
Member

@physikerwelt If there is nothing wrong with this pull request, could you merge it please.

@@ -196,6 +196,17 @@ ast.Tex.defineVisitor("contains_func", {
match(target, '\\end{'+t+'}') ||
matrix_has(m);
},
MULTLINE: function(target, t, m) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the difference in the functions for multine and matrix. Can't you just create one functaion and assign it to both keys MATRIX and MULTILINE

@notjagan notjagan changed the title Add support for multline and multline*. Add support for multline and multline* Aug 23, 2016
@physikerwelt
Copy link
Member

physikerwelt commented Aug 24, 2016

@HowardCohl what is the difference between {multline} and {align} beside http://tex.stackexchange.com/questions/239252/what-is-the-difference-between-split-multline-align-breqn-for-breakin. For each language construct we add into astutil we need to implement special visitor in other tools that base on texvc such as texer or texvcinfo https://github.com/physikerwelt/texvcinfo/blob/master/lib/extractors/subscripts.js#L77-L153

@notjagan can you take a moment to investigate parser.pegjs and figure out if there is a simpler way to support {multiline} in the same way as {align} is supported at the moment. And could you also make a seperate pull request for the starred commands. I think we should consistently support starts for all environments that have the star option.

@notjagan notjagan changed the title Add support for multline and multline* Add support for multline Aug 24, 2016
@physikerwelt
Copy link
Member

is this ready to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants