-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multline #48
base: master
Are you sure you want to change the base?
Conversation
please rebase |
@notjagan Have you rebased yet? |
@physikerwelt I have now merged the branch to reflect the changes made in #46 and updated the code to work with pegJS 0.10.0. If/when this gets merged in, I will then create a pull request to similarly add |
@physikerwelt If there is nothing wrong with this pull request, could you merge it please. |
@@ -196,6 +196,17 @@ ast.Tex.defineVisitor("contains_func", { | |||
match(target, '\\end{'+t+'}') || | |||
matrix_has(m); | |||
}, | |||
MULTLINE: function(target, t, m) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the difference in the functions for multine and matrix. Can't you just create one functaion and assign it to both keys MATRIX and MULTILINE
@HowardCohl what is the difference between @notjagan can you take a moment to investigate |
is this ready to be merged? |
This is simply an intermediate pull request for before #46 is merged. I do not expect this to pass the checks because it will once this is merged in and the other request is merged in since the other request fixes the checks itself.