Updates SpiceClient to handle redirect requests #5696
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Older versions of ISIS still use the old https://services.isis.astrogeology.usgs.gov/cgi-bin/spiceinit.cgi URL. To fix this we had a redirect in place to the new URL: https://astrogeology.usgs.gov/apis/ale/v0.9.1/spiceserver/. Unfortunately, QNetworkRequest doesn't directly handle redirects and requires additional code to look for a redirect before issuing a new request. This does not solve the issue of older version of ISIS using the old URL unless this change is backported, but will address any future URL's that we may want to redirect.
Related Issue
Multiple issues regarding spiceinit not working on 8.1.0 and older. Like mentioned above this will not fix older versions unless we backport these changes.
How Has This Been Validated?
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: