Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates SpiceClient to handle redirect requests #5696

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

amystamile-usgs
Copy link
Contributor

@amystamile-usgs amystamile-usgs commented Dec 20, 2024

Description

Older versions of ISIS still use the old https://services.isis.astrogeology.usgs.gov/cgi-bin/spiceinit.cgi URL. To fix this we had a redirect in place to the new URL: https://astrogeology.usgs.gov/apis/ale/v0.9.1/spiceserver/. Unfortunately, QNetworkRequest doesn't directly handle redirects and requires additional code to look for a redirect before issuing a new request. This does not solve the issue of older version of ISIS using the old URL unless this change is backported, but will address any future URL's that we may want to redirect.

Related Issue

Multiple issues regarding spiceinit not working on 8.1.0 and older. Like mentioned above this will not fix older versions unless we backport these changes.

How Has This Been Validated?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5696".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant