-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Csv2Table Column Type Update #5631
base: dev
Are you sure you want to change the base?
Conversation
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5631". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes look good. Does this need tests, or do existing tests capture everything?
@AustinSanders, yes a couple tests need to go in and I am updating existing app tests to gtests |
The build and test suite have started for your pull request. To view your build log, please reference the build with source version: "PR_5631". Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs a changelog entry then good to go!
Description
Change to csv2table that allows the user to pass TableField types through
Related Issue
N/A
How Has This Been Validated?
Needs a test
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: