output.tlscli #96
output.tlscli #96
Conversation
nicki-krizek
force-pushed
the
add-tls
branch
7 times, most recently
from
c9d4286 to
a007935
Compare
|
Updated with the latest working version. The TLS client is basically the TCP client, with removed unused non-blocking mode (#101) and added TLS session. I've also had to remove the |
- `output.tlscli`: - Fix required package for Travis - Regenerate `Makefile.am` - Reformat code - Add function name on errors - Fix timeout handling - Remove debug output - Moved GnuTLS credentials and session initialization to `output_tlscli_init()` - Track TLS establish state in `tls_ok`
|
#build |
|
@tomaskrizek Please test my changes. |
- `examples/replay.lua`: Add `-T` for TLS - `output.tlscli`: - Call `gnutls_global_init()`, support for older versions - Disable `poll()` code, timeout handled by GnuTLS - Fix include headers - Require `dnsjit.core.compat_h` for GnuTLS types
|
Thanks for the changes! The only issue I see is when the response times out - lua receives |
- `output.tlscli`: - Remove `poll()` code - Return zero length payload on timeout while receiving DNS length
|
@tomaskrizek Are you sure? It should only return 0 if there is an error, I can't see where it would return 0 on timeout. |
|
Looking at e4ddbf1, I think the right action to do when we get |
|
I can't find in the docs that I can only find that it is used for the DTLS features. Have you tested this? |
|
Yes, I can verify this with GnuTLS 3.6.4. |
- `output.tlscli`: - Don't treat interrupted like timed out / try again, same behavior for UDP/TCP client - Handle `GNUTLS_E_TIMEDOUT`
|
@tomaskrizek The behavior is the same as the other clients now, please test. |
|
@jelu Seems to work fine now, thanks! |
- Make GnuTLS required for building - Update dependencies in documentation and packages
basic TLS client with no certificate validation.