Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary SDE resampling in PPO update #1933

Merged
merged 9 commits into from
Jun 29, 2024
Merged

Conversation

brn-dev
Copy link
Contributor

@brn-dev brn-dev commented May 22, 2024

Description

Remove policy.reset_noise() call in PPO update

Motivation and Context

Resampling the SDE noise in the PPO update is unnecessary, for more info see #1929

  • I have raised an issue to propose this change (required for new features and bug fixes)

closes #1929

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have opened an associated PR on the SB3-Contrib repository (if necessary)
  • I have opened an associated PR on the RL-Zoo3 repository (if necessary)
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

Copy link
Member

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR =)
could you do the same for PPO variants in SB3 contrib?

@araffin
Copy link
Member

araffin commented Jun 29, 2024

I've created a report to check that it had no impact on the performance (it changes results because the state of the pseudo-random generator is not the same but should not impact performance):
https://wandb.ai/openrlbenchmark/sb3/reports/PR-1933-Remove-gSDE-resampling--Vmlldzo4NDk4Nzgx

Copy link
Member

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks =)

@araffin araffin merged commit 24ebf1a into DLR-RM:master Jun 29, 2024
4 checks passed
friedeggs pushed a commit to friedeggs/stable-baselines3 that referenced this pull request Jul 22, 2024
* Remove unnecessary SDE resampling in PPO update

* Update changelog.rst

* Update version

* Update PyTorch version on CI

* Update ruff

* Limit NumPy version

* Reformat

---------

Co-authored-by: Antonin RAFFIN <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Why resample SDE noise matrices in PPO optimzation?
2 participants