Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: opentelementry support (update of #14668) #16087

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

Candinya
Copy link
Contributor

@Candinya Candinya commented Jul 5, 2024

Involved Issue / 该 PR 相关 Issue

Close #14668

Example for the Proposed Route(s) / 路由地址示例

NOROUTE

New RSS Route Checklist / 新 RSS 路由检查表

  • New Route / 新的路由
  • Anti-bot or rate limit / 反爬/频率限制
    • If yes, do your code reflect this sign? / 如果有, 是否有对应的措施?
  • Date and time / 日期和时间
    • Parsed / 可以解析
    • Correct time zone / 时区正确
  • New package added / 添加了新的包
  • Puppeteer

Note / 说明

Basically an updated version of #14668 , with some mentioned errors fixed.

incubator4 and others added 3 commits March 8, 2024 10:48
# Conflicts:
#	lib/app.tsx
#	lib/init-routes.ts
#	lib/middleware/access-control.ts
#	package.json
#	pnpm-lock.yaml
#	scripts/workflow/build-radar.ts
#	website/docs/install/config.md
@github-actions github-actions bot added dependencies This PR involves changes to dependencies core enhancement Route Auto: Route Test Skipped PR involves no routes labels Jul 5, 2024
});

const exporter = new OTLPTraceExporter({
// optional OTEL_EXPORTER_OTLP_ENDPOINT=https://localhost:4318
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be updated thru env variable, isn't it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be updated thru env variable, isn't it?

due to https://www.npmjs.com/package/@opentelemetry/exporter-trace-otlp-http
this env would be auto load by this package

@TonyRL TonyRL merged commit 68c7430 into DIYgod:master Jul 5, 2024
25 of 27 checks passed
@Candinya Candinya deleted the feat/otel branch July 5, 2024 12:17
wonktondI pushed a commit to wonktondI/RSSHub that referenced this pull request Jul 28, 2024
…6087)

* chore: squash commit

* fix: tweak some mentioned issues

---------

Co-authored-by: incubator4 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto: Route Test Skipped PR involves no routes core enhancement dependencies This PR involves changes to dependencies Route
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants