Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(route): BBC article #15591

Merged
merged 1 commit into from
May 16, 2024
Merged

fix(route): BBC article #15591

merged 1 commit into from
May 16, 2024

Conversation

Zebartin
Copy link
Contributor

Involved Issue / 该 PR 相关 Issue

Close #15568

Example for the Proposed Route(s) / 路由地址示例

/bbc/world-asia

New RSS Route Checklist / 新 RSS 路由检查表

  • New Route / 新的路由
  • Anti-bot or rate limit / 反爬/频率限制
    • If yes, do your code reflect this sign? / 如果有, 是否有对应的措施?
  • Date and time / 日期和时间
    • Parsed / 可以解析
    • Correct time zone / 时区正确
  • New package added / 添加了新的包
  • Puppeteer

Note / 说明

Replacing hostname should be enough for the moment.

@github-actions github-actions bot added Route Auto: Route Test Complete Auto route test has finished on given PR labels May 15, 2024
Copy link
Contributor

Successfully generated as following:

http://localhost:1200/bbc/world-asia - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/><code class="mt-2 block max-h-28 overflow-auto bg-zinc-100 align-bottom w-fit details">FetchError: [GET] &quot;https://www.bbc.co.uk/articles/cpwg0g8ejyxo&quot;: 403 Forbidden Edge 5</code>
Route: <code class="ml-2 bg-zinc-100">/bbc/:site?/:channel?</code>
Full Route: <code class="ml-2 bg-zinc-100">/bbc/world-asia</code>
Node Version: <code class="ml-2 bg-zinc-100">v21.7.3</code>
Git Hash: <code class="ml-2 bg-zinc-100">8ac69df6</code>

@Zebartin
Copy link
Contributor Author

403 error is probably due to too many requests in a short duration triggering BBC's rate limit. Works fine if there are enough items cached.

Copy link
Collaborator

@TonyRL TonyRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks guid.

@Zebartin
Copy link
Contributor Author

I dont get it. This commit does not change guid, and it is exactly the same as that in the original BBC RSS feed. Should guid and link be set to the new link with new hostname as well?

@TonyRL TonyRL merged commit 9019b5b into DIYgod:master May 16, 2024
27 checks passed
CaoMeiYouRen pushed a commit to CaoMeiYouRen/RSSHub that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto: Route Test Complete Auto route test has finished on given PR Route
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BBC route fails to fetch content for some article
2 participants