Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow missing line break at eof #38

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Allow missing line break at eof #38

merged 1 commit into from
Jul 16, 2024

Conversation

oleks
Copy link
Member

@oleks oleks commented Jul 13, 2024

Related to #36

P.S. Should we also just purge the ReadP parser?

@oleks oleks requested review from athas and kirkedal July 13, 2024 05:47
@athas
Copy link
Contributor

athas commented Jul 13, 2024

Yes, please allow this.

I would also suggest using Megaparsec for the parser instead, so the error messages are less bad.

@oleks
Copy link
Member Author

oleks commented Jul 13, 2024

I would also suggest using Megaparsec for the parser instead, so the error messages are less bad.

I agree #39.

@oleks oleks merged commit 6ca5e08 into DIKU-EDU:master Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athas athas athas approved these changes

@kirkedal kirkedal Awaiting requested review from kirkedal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleks @athas