support average in generic concat #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecomodeller
reviewed
Mar 27, 2025
tests/test_generic.py
Outdated
|
|
||
| def test_concat_average(tmp_path: Path) -> None: | ||
| # Test for multiple items? | ||
| g = mikeio.Grid1D(x=range(5), projection="LONG/LAT") |
There was a problem hiding this comment.
projection is not meaningful for Grid1D. I would skip it.
ecomodeller
reviewed
Apr 3, 2025
mikeio/generic.py
Outdated
| if not last_file: | ||
| dfs_n = DfsFileFactory.DfsGenericOpen(str(infilenames[i + 1])) | ||
| nf = dfs_n.FileInfo.TimeAxis.StartDateTime | ||
| next_start_time = datetime( |
There was a problem hiding this comment.
Why is this step necessary, isn't nf already a datetime?
ecomodeller
reviewed
Apr 3, 2025
tests/test_generic.py
Outdated
| da_x0 = ds[0].isel(x=0) | ||
|
|
||
| assert np.allclose( | ||
| da_x0.values.flatten(), |
There was a problem hiding this comment.
no you right, for a 1d array flatten is not needed. will remove it
ecomodeller
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.