Upgrade AWS SDK DynamoDB from v2 > v3 #2062
Conversation
|
lailien3
force-pushed
the
feature/iwtf-3449-aws-v2-to-v3
branch
2 times, most recently
from
780efb8 to
c8bf535
Compare
lailien3
force-pushed
the
feature/iwtf-3449-aws-v2-to-v3
branch
from
b0adb0e to
b806cb0
Compare
lailien3
force-pushed
the
feature/iwtf-3449-aws-v2-to-v3
branch
2 times, most recently
from
601bfd0 to
ba82ad1
Compare
|
There was a problem hiding this comment.
I've reviewed some of this, and I'm noticing common issues, such as use of let rather than const, multiple expect statements in tests and enforcement of a particular implementation via tests, rather than testing an expected result after particular inputs. Please could you check through yourself for further instances of these (I've highlighted the first few). Also, you're touching areas of the codebase that haven't been looked at since it was first written, and I'd say this is an opportunity to rewrite the over-complicated tests into the style we use now. Have a look through yourself and then we can go through it together?
| const firstCall = ddbMock.call(0).args[0].input | ||
| expect(firstCall.RequestItems.NameOfTableToUpdate).toHaveLength(3) | ||
| const secondCall = ddbMock.call(1).args[0].input | ||
| expect(secondCall.RequestItems.NameOfTableToUpdate).toHaveLength(2) |
There was a problem hiding this comment.
I'd say that the existing tests need to be completely rewritten; they're pretty complex and again, enforce a particular implementation. This is possibly better talked through, so give me a shout when you want to look at this.
lailien3
force-pushed
the
feature/iwtf-3449-aws-v2-to-v3
branch
from
0f748cc to
8ccc00f
Compare
rPlease enter the commit message for your changes. Lines starting
lailien3
force-pushed
the
feature/iwtf-3449-aws-v2-to-v3
branch
from
a81a092 to
e5ca3fa
Compare
|
https://eaflood.atlassian.net/browse/IWTF-3449
This ticket is part of upgrading rod-licensing from using the AWS SDK v2 to v3.
This ticket specifically covers upgrading the parts of our codebase that use the AWS SDK to use DynamoDB
(NOT SecretsManager, S3 or SQS yet)
We expect this to be the largest and most complex bit of the SDK upgrade.