Implement recurring payments #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setup recurring payments job
lailien3
added
enhancement
…get the latest version without having to publish it
jaucourt
requested changes
Mar 22, 2024
packages/sales-api-service/src/services/__tests__/recurring-payments.service.spec.js
Outdated
Show resolved
Hide resolved
packages/sales-api-service/src/services/transactions/process-transaction-queue.js
Outdated
Show resolved
Hide resolved
packages/sales-api-service/src/services/recurring-payments.service.js
Outdated
Show resolved
Hide resolved
jaucourt
requested changes
Mar 26, 2024
There was a problem hiding this comment.
One last thing, plus did you create the ticket I asked about here: #1909 (comment)?
| /** | ||
| * Process a recurring payment instruction | ||
| * @param transactionRecord | ||
| * @returns {Promise<{recurringPayment: null}>} |
There was a problem hiding this comment.
This isn't quite what I said. In the @returns comment, you're specifying the type of the return value. What you're saying here is that it returns a Promise that resolves to an object with the key recurringPayment that is always null.
|
jaucourt
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup recurring payments job