call application validation on app submit #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will this break application submissions? We might want to add applicationValidationRunId to GAS ahead of this change. We can do it ourselves, here you can see our current grant definition: https://fg-gas-backend.dev.cdp-int.defra.cloud/grants/frps-private-beta And here is the PUT endpoint you can use to modify the object: https://fg-gas-backend.dev.cdp-int.defra.cloud/documentation#/tmp/putTmpGrantsCode |
dcapilla
reviewed
Sep 16, 2025
src/server/common/helpers/grant-application-service/state-to-gas-payload-mapper.js
Outdated
Show resolved
Hide resolved
dcapilla
reviewed
Sep 16, 2025
dcapilla
reviewed
Sep 16, 2025
timney
commented
Sep 17, 2025
timney
force-pushed
the
feat/app-validation
branch
from
f43f8c6 to
0a04276
Compare
dcapilla
reviewed
Sep 18, 2025
src/server/common/helpers/grant-application-service/state-to-gas-payload-mapper.test.js
Outdated
Show resolved
Hide resolved
dcapilla
previously approved these changes
Sep 18, 2025
timney
force-pushed
the
feat/app-validation
branch
from
cc3b119 to
e606bc1
Compare
|
AndrewKeig
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a dependency on the GAS api being able to handle the new 'applicationValidationRunId'