ALVS Schema Validation #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CDMS-188 setting concurency * CDMS-188 options for concurrency working * Fixed test
Task/cdms 118 coding standards
Updated Contact details to be sensitive, so they are redacted
added service bus details, and health checks and diagnostics to test …
updated asb to use WebProxy which was part of TDM
* Initial attempt at decisions * Some updates to decisions, to refactor out into a matching service * merge conflicts * updated test data * updated generated code * reverted the decision finders back * commented out decisions as its not ready yet * removed commented out code --------- Co-authored-by: Thomas Anderson <[email protected]>
Co-authored-by: Thomas Anderson <[email protected]>
* CDMS-200 refactoring to make decision analytics easier * CDMS-200 refactors analytics chart mechanism to run in parrallel and allow charts to be specified * CDMS-200 get history of movement from /analytics/history * CDMS-200 removes commented out lines * Fixes wait()
* CDMS-200 add test for movement not found CDMS-200 improved CachingBlobService implementation * CMDS-200 fixes tests * CDMS-200 refactors message processing * removes new test * Add decions in test generator and push to blob storage * Tidies up audit entry timings and source systems * Fixes up tests * Adds context to decisions * make audit entry version nullable * Handles checks in clearance request builder * Try to send clearance requests with the DecisionNumber set to the decision consumer * Updated TestDataGeneratorHelpers to use the bus to route to the consumers rather than call directly * tidy up the switch statement further * CDMS-200 adds ability to control sequencing of messages to builders * Switch Decisions to their own type * Switched back to using consumers directly * Finishes initial decision metrics * Tidied up code errors * Fixed up tests --------- Co-authored-by: Thomas Anderson <[email protected]>
* Added Ched finders logic * updated decision service not to send out decision when no checks exist and updated tests * tidy up some code * Updated tests * Fixed up check tests --------- Co-authored-by: Thomas Anderson <[email protected]> Co-authored-by: Craig Edmunds <[email protected]>
* CDMS-200 analytics adjustments for novembers prod data * Decision analytics by system and decision code working * lastMonthsDecisionsByDecisionCode Chart that doesn't seperate linked vs not linked, and added totals * First pass at decision analytics working * Finishes summary of decsisions * Fixes tests
* CDMS-200 initial version of decision refactoring * Adds decision context to audit log * Incorporates new decision context in lastMonthsDecisionsByDecisionCode analytics
#30) * CDMS-200 adding decision integration tests & refactoring ApplicationFactory * CDMS-200 refactored integration testing setup & btms client * Decision test is now very simple to extend * ChedP decision test working
* CDMS-200 started refactoring of movement builder out of movement * Further refactoring out of movement * Starting to add more complex decision scenarios * CDMS-200 multi stage scenario working and illustrating issue when multiple versions of notifications are received * Refactors check status to make decision context more readable
* Updated README with instructions on how to set up test data. * Made a couple of fixes.
CDMS-144 handle unmatched CHED
… processing (#34) * Refactoed decision test to feed directly into consumers * Refactoring to allow scenarios to be extracted from data lake into scenario folders * Completed refactoring of in memory test fixture
* Use generic container auth * updated health check --------- Co-authored-by: Thomas Anderson <[email protected]>
…rnal and external understanding of decision code (#155) * CDMS-374 seperates decisions from clearance requests in the internal model Updates decision related tests to use seperated decision code & internal decision code * Drop indexes that no longer exist
* Did some refactoring, and updated the client factory for SMB * formatting issues * removed using * formatting * fixed tests * formatting --------- Co-authored-by: Thomas Anderson <[email protected]>
* created sub module * include sub modules * include token * changed paths * updated path to test data * updated path on submodule --------- Co-authored-by: Thomas Anderson <[email protected]>
* Did some refactoring, and updated the client factory for SMB * formatting issues * removed using * formatting * fixed tests * formatting * Added decision sqs consumer * updates * updated app settings * rename * added logging * formatting --------- Co-authored-by: Thomas Anderson <[email protected]>
Co-authored-by: Thomas Anderson <[email protected]>
* made message optional * Removed SQS consumers --------- Co-authored-by: Thomas Anderson <[email protected]>
Co-authored-by: Lim Sim <[email protected]>
* First pass at csv output * Switch to Results.File, download works
* added finalsation consumer for sqs * formatting * formatting * formatting --------- Co-authored-by: Thomas Anderson <[email protected]>
Co-authored-by: Lim Sim <[email protected]>
* updated decision service to only return X00 if no decision finder is returned for an item * formatting * formatting * added test * updated test data --------- Co-authored-by: Thomas Anderson <[email protected]>
…sts (#195) * Updated decision finders along with can find decision criteria and tests * formatting * formatting * handled deleted notifications --------- Co-authored-by: Thomas Anderson <[email protected]>
#200) * updated decision finders to look at the not acceptable reason if there is no not acceptable action set * removed duplicate code --------- Co-authored-by: Thomas Anderson <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added ALVS schema validation
It makes use of Fluent Validation for the rules, that way when the model validation rules are implemented they can also use fluent validation, so all validation logic is done is a consistent manor.
There is also feature flags to control the validation, which by default is turned off.