Suggested fixes to the DcmBaseSCPPool class. #133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vovasch
commented
Nov 20, 2025
Vovasch
commented
- The destructor of the DcmBaseSCPPool class might never exit.
- Access violation exception thrown when the destructor of the DcmBaseSCPPool is called before all worker threads have finished and reported.
added 2 commits
November 20, 2025 14:33
Current implementation of DcmBaseSCPPool's destructor waits for the m_runMode to be set to SHUTDOWN. If m_runMode never set to SHUTDOWN the destructor will wait forever in the 'while' cycle. Two cases when m_runMode is not set to SHUTDOWN: Case 1: The m_runMode won't be set to SHUTDOWN if DcmBaseSCPPool::listen() was never called. Fix: Changed default value of m_runMode from LISTEN to SHUTDOWN. The m_runMode is set to LISTEN inside of the DcmBaseSCPPool::listen() function. Case 2: Call to initializeNetwork() in the DcmBaseSCPPool::listen() function might return bad condition. In that case m_runMode won't be set to SHUTDOWN due to early return. Fix: Add a call to the newly added finishListening() function in case of early return.
…or of the pool was called. There is no guarantee that all worker threads have completed their work when when m_runMode is set to SHUTDOWN. Added an additional condition to the while loop to wait until all workers have completed their tasks and reported to the pool. After that it's guarantied that all workers are in the m_workerIdle list and can be safely joined.
Author
|
Link to the forum discussion. |
Member
|
Hi Vovasch, thank you very much for the detailed report and fixes. I merged them into the main repo and they will be visible on master during the next days. Best regards, |
Author
|
Hi Michaelonken, Thank you for your attention to this matter. Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.