Skip to content

Conversation

@parasite-lost
Copy link

Added support for the optional attribute Patient's Age from the Patient Study Module. The new attribute is written to and read from DICOM dataset as well as to/from the dcmsr-specific XML document format.

Also extended test case to check whether the get and set methods work as expected.

Added support for the optional attribute Patient's Age from the Patient
Study Module. The new attribute is written to and read from DICOM
dataset as well as to/from the dcmsr-specific XML document format.

Also extended test case to check whether the get and set methods work
as expected.
@jriesmeier
Copy link
Member

jriesmeier commented Aug 22, 2025

@parasite-lost Thank you for your PR, which was almost perfect (only the definition of type dsr:AgeString was missing in the XML Schema). I've just committed the required changes to the local testing branch and will make the changes publicly available as soon as our test servers are happy with it.

@parasite-lost
Copy link
Author

@parasite-lost Thank you for your PR, which was almost perfect (only the definition of type dsr:AgeString was missing in the XML Schema). I've just committed the required changes to the local testing branch and will make the changes publicly available as soon as our test servers are happy with it.

Thank you!

I was wondering whether the XML schema required adjustments but didn't look closely enough whether and where to apply the respective changes. Thanks for taking care of it!

michaelonken pushed a commit that referenced this pull request Sep 1, 2025
Added support for the optional attribute Patient's Age from the Patient
Study Module. This attribute is now written to and read from a DICOM
dataset as well as to/from the dcmsr-specific XML document format (see
"dsr2xml.xsd"). There are also new get and set methods. However, the
Patient's Age is neither printed to the console (see "dsrdump") nor
rendered for the (X)HTML output (see "dsr2html").

Also extended existing test case in order to check whether the get and
set methods work as expected.

Thanks to GitHub user "parasite-lost" (Ulrich Dorsch) for the original
patch, which is almost identical to this commit.

This closes GitHub PR #126.
@jriesmeier
Copy link
Member

See commit c551901.

@jriesmeier jriesmeier closed this Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants