Streamline integration by linking socket libraries only when required #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DCMTK no longer unconditionally test or link against
nslandsocket. These libraries are now only considered on pre-11.4 Solaris systems, where functions such asgethostbynamewere historically provided outside libc.On modern systems (Linux, BSD, macOS, Solaris >= 11.4), networking APIs (
gethostbyname,getaddrinfo,socket, etc.) are provided directly by libc, so linking-lnslor-lsocketis unnecessary.This streamlines integration of DCMTK into external projects by removing dependencies on libraries that may directly or indirectly pull in a different OpenSSL version than the one bundled with the application.
Background:
-lsocket -lnslfor basic networking.libnslfunctionality has been folded into libc.Verification:
libnsl-only symbols are referenced in DCMTK by grepping sources against the exported symbol set oflibnsl.References: