searhcHits as field in manifestations :) #480
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YousefMohsen
approved these changes
Jan 23, 2025
kfudbc
reviewed
Jan 23, 2025
src/schema/draft/manifestation.js
Outdated
| """ | ||
| Complex search only !!! - manifestations with search hits | ||
| """ | ||
| searchHits: [Manifestation] |
There was a problem hiding this comment.
Tror lige så godt vi kan pakke den ind i en SearchResultEntry type med det samme
kfudbc
reviewed
Jan 23, 2025
src/utils/utils.js
Outdated
| @@ -366,6 +366,14 @@ export async function resolveWork(args, context) { | |||
| profile: context.profile, | |||
| }); | |||
|
|
|||
| const resolvedSearchHits = args?.searchHits | |||
There was a problem hiding this comment.
brug manifestations->all i stedet for at hente data ud igen
kfudbc
approved these changes
Jan 24, 2025
| } | ||
|
|
||
| type HighLightType { | ||
| hit: String |
There was a problem hiding this comment.
HighLightType skal nok justeres, hvis vi når dertil
Vi vil gerne kunne vise hele feltet der er hittet og så markere den del af strengen der er hittet.
Men fint til en start
|
|
||
| type SearchHitsType { | ||
| match: Manifestation |
There was a problem hiding this comment.
synes match er et godt navn, bravo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.