Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix calibration chart edge case #6552

Merged
merged 3 commits into from
Feb 11, 2025
Merged

fix calibration chart edge case #6552

merged 3 commits into from
Feb 11, 2025

Conversation

blanchco
Copy link
Contributor

@blanchco blanchco commented Feb 10, 2025 •
edited
Loading

Description

  • Fixes an edge case in the parameter distribution charts where if the parameter was a constant the displayed data would be confusing to the user as to what number is shown on the chart.
  • To fix this I have removed binning when the parameter is a constant so that it will only show a bar at the constant value as seen below:

BEFORE:
Screenshot 2025-02-10 at 2 14 42 PM

AFTER:
Screenshot 2025-02-10 at 2 10 35 PM

Resolves #(issue)

@blanchco blanchco self-assigned this Feb 10, 2025
YohannParis
YohannParis approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the typing.

@blanchco blanchco linked an issue Feb 10, 2025 that may be closed by this pull request
[BUG]: Graphs of parameters post-calibration look the same for parameters with different values #6191
Closed
@mwdchang mwdchang merged commit 0f5ccf0 into main Feb 11, 2025
2 checks passed
@mwdchang mwdchang deleted the calibration-chart-edge-case branch February 11, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis approved these changes

@mwdchang mwdchang mwdchang approved these changes

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@mloppie mloppie Awaiting requested review from mloppie mloppie is a code owner

Assignees

@blanchco blanchco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Graphs of parameters post-calibration look the same for parameters with different values
3 participants
@blanchco @YohannParis @mwdchang