Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix intervention policy scenario chart selection #6255

Merged
merged 4 commits into from
Jan 28, 2025
Merged

fix intervention policy scenario chart selection #6255

merged 4 commits into from
Jan 28, 2025

Conversation

blanchco
Copy link
Contributor

Description

  • fixes an issue in some scenarios where intervention policy chart select would just be blank.
    Fixes:
  • do not add intervention policies chart selection if the policy is blank
  • added chart selection support for horzion scanning and value of information templates

@blanchco blanchco self-assigned this Jan 27, 2025
@blanchco blanchco linked an issue Jan 27, 2025 that may be closed by this pull request
[BUG]: intervention created through template not recognized in simulate #6219
Closed
YohannParis
YohannParis approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgauldie dgauldie merged commit 1fa256f into main Jan 28, 2025
4 checks passed
@dgauldie dgauldie deleted the fix-intervention-policy-scenario-chart-selection branch January 28, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis approved these changes

@shawnyama shawnyama shawnyama approved these changes

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1

Assignees

@blanchco blanchco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: intervention created through template not recognized in simulate
4 participants
@blanchco @YohannParis @shawnyama @dgauldie